Start fixing govulncheck job by upgrading makefile modules#640
Merged
SgtCoDFish merged 1 commit intomasterfrom Mar 14, 2025
Merged
Start fixing govulncheck job by upgrading makefile modules#640SgtCoDFish merged 1 commit intomasterfrom
SgtCoDFish merged 1 commit intomasterfrom
Conversation
0c5ddb4 to
9835005
Compare
This also requires skipping some pod security scanners which were added in upstream makefile-modules and started failing. It would be best to fix those issues in a separate commit, so it's easier to roll them back and to facilitate discussion on whether those changes are safe. Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
9835005 to
8885746
Compare
maelvls
approved these changes
Mar 14, 2025
Member
maelvls
left a comment
There was a problem hiding this comment.
thanks for spending the time fixing this!
Member
|
Thanks for adding the table. I see that we are not complying with two of the policies: disallow-privilege-escalation and restrict-seccomp-strict. Do you need help fixing these? |
Contributor
Author
I think they're easy to fix, but I don't have the bandwidth today to ensure that they're safe to change for the agent. If you know that the agent doesn't require privilege escalation / if we can adhere to the strict seccomp policy, then by all means we should fix that straight away! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is fixed by upstream makefile modules.
I ran:
IMPORTANT: Note that this skips two pod security static checks which came from upstream makefile-modules. I didn't want to fix those in this PR, since that would expand the scope of the PR beyond a makefile-modules bump. We'll need to discuss changing the chart to address those reports soon, but that doesn't block this PR
See make/verify-pod-security-standards-exceptions.yaml for the skipped checks; without them, the CI would fail: