[VC-35738] Feature Branch #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a second server (#600) Signed-off-by: Richard Wall <richard.wall@venafi.com>
…at (#596) * Log with klog to stdout and stderr in Kubernetes text format Signed-off-by: Richard Wall <richard.wall@venafi.com> Co-authored-by: Maël Valais <mael@vls.dev>
Instead of using log.Fatal in some of them Signed-off-by: Richard Wall <richard.wall@venafi.com>
* Test that one-shot mode exits * Stop the server when the context is cancelled
…entrally instead of using log.Fatal at multiple sites (#599) * Bubble up the errors from sub-commands and handle errors centrally instead of using log.Fatal at multiple sites * Log the bubbled up error instead of printing it * Turn on SilenceErrors and SilenceUsage to prevent Cobra from messing up the stderr output * Remove obsolete translations for converting log.printf to error messages
…606) * Append errgroup errors to Run return error * Fail TestRunOneShot if Run returns errors
…Go Routines (#605) Signed-off-by: Richard Wall <richard.wall@venafi.com>
And use the Execute function Signed-off-by: Richard Wall <richard.wall@venafi.com>
…e realistic (#611) Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
…emaining code (#612) Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
maelvls
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
We have discussed the idea of merging this before releasing 1.3.0. I'm OK with this: I feel confident that the logging changes won't be affecting customers thanks to the lots of unit tests as well as with the manual tests performed by Richard throughout the PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR and feature branch contains all the changes from the following PRs, each of which has been code reviewed.
I created this feature branch because I did not want the individual changes to be included in the v1.2.0 release which we created last week.
PRs: