fix: runAsUser in yaml is unneeded as its set in the Dockerfile#546
Merged
SgtCoDFish merged 1 commit intomasterfrom Jul 10, 2024
Merged
fix: runAsUser in yaml is unneeded as its set in the Dockerfile#546SgtCoDFish merged 1 commit intomasterfrom
SgtCoDFish merged 1 commit intomasterfrom
Conversation
This also fixes an issue in OpenShift where OpenShift wants you to use a certain range of UIDs that 1000 does not fall into. By not specifying an runAsUser in the yaml, OpenShift picks a appropriate UID for you. Since the Dockerfile contains the USER directive this should have no effect on non OpenShift Kubernetes clusters. Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
SgtCoDFish
approved these changes
Jul 10, 2024
Contributor
SgtCoDFish
left a comment
SgtCoDFish
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Seems reasonable given the openshift situation!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also fixes an issue in OpenShift where OpenShift wants you to use a certain range of UIDs that 1000 does not fall into:
By not specifying an runAsUser in the yaml, OpenShift picks a appropriate UID for you:
Since the Dockerfile contains the USER directive this should have no effect on non OpenShift Kubernetes clusters.