Skip to content

feat: Config and Argument configuration plus tests for these features#464

Merged
hawksight merged 2 commits intomasterfrom
pf/agent-args
Sep 25, 2023
Merged

feat: Config and Argument configuration plus tests for these features#464
hawksight merged 2 commits intomasterfrom
pf/agent-args

Conversation

@hawksight
Copy link
Member

@hawksight hawksight commented Sep 14, 2023

Helps to resolve #438 as it adds helm unittest to test the new features added.

Allows:

  • Passing extraArgs to the agent.
  • Allows you to embed the agent config as completely custom in the chart
  • Allows you to specify a completely different configmap (& key) so config is not within the chart.
  • Update to v0.1.40 of agent.
  • CronJobs to v1 not v1beta1

@hawksight
Copy link
Member Author

hawksight commented Sep 15, 2023

Kind of a little stuck on ensuring the actual config.yaml file is templated correctly.
See this issue for context.

Got an answer and used the snapshot feature to test default configmap settings.

Signed-off-by: Peter Fiddes <peter.fiddes@gmail.com>
@hawksight hawksight changed the title WIP: TEST GH Actions CI feat: Config and Argument configuration plus tests for these features Sep 15, 2023
@hawksight hawksight marked this pull request as ready for review September 15, 2023 16:42
…installer

Signed-off-by: Peter Fiddes <peter.fiddes@gmail.com>
@hawksight
Copy link
Member Author

I think this is ready for a review now. Appreciate a good set of eyes on this as I've bumped to v0.3.0 as there's a fair few changes around config options here.

Copy link

@SpectralHiss SpectralHiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 1 minor suggestion to change the override "interface" a little bit.

@hawksight
Copy link
Member Author

Had a huddle with @SpectralHiss to see if we could make the chart simpler with:

  override:
    # -- Embed the agent configuration here in the chart values
    config: 
    # -- Sepcify ConfigMap details to load config from existing ConfigMap
    configmap:
      name: 
      key: 

Or even simpler with a default of:

  override: {}

However it turned out to be too difficult to make the logic cleaner in the chart.
So for now we agreed to leave how it is and improve for the next version of the chart that will be Venafi Specific

Comment on lines +41 to +47
# agent-RELEASE-NAME
# Diff:
# --- Expected
# +++ Actual
# @@ -1,2 +1,2 @@
# -agent-*
# +agent-RELEASE-NAME
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a result of a merge conflict.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I was including this as the result of one of the unit tests. It actually depends what you enter as the nameOverride as to whether it counts the -RELEASE-NAME part. It caught me out as if you just use helm template --set nameOverride=agent ... then you don't see the RELEASE-NAME part. I wanted to include the output so I don't forget this subtly in the future :)

@hawksight hawksight merged commit 55bd887 into master Sep 25, 2023
@hawksight hawksight deleted the pf/agent-args branch September 25, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chart CI to identify issues before merging

4 participants