feat: Config and Argument configuration plus tests for these features#464
feat: Config and Argument configuration plus tests for these features#464
Conversation
|
Got an answer and used the snapshot feature to test default configmap settings. |
Signed-off-by: Peter Fiddes <peter.fiddes@gmail.com>
1bf0fbf to
3b0b6e7
Compare
…installer Signed-off-by: Peter Fiddes <peter.fiddes@gmail.com>
|
I think this is ready for a review now. Appreciate a good set of eyes on this as I've bumped to v0.3.0 as there's a fair few changes around config options here. |
SpectralHiss
left a comment
There was a problem hiding this comment.
Only 1 minor suggestion to change the override "interface" a little bit.
|
Had a huddle with @SpectralHiss to see if we could make the chart simpler with: override:
# -- Embed the agent configuration here in the chart values
config:
# -- Sepcify ConfigMap details to load config from existing ConfigMap
configmap:
name:
key: Or even simpler with a default of: override: {}However it turned out to be too difficult to make the logic cleaner in the chart. |
| # agent-RELEASE-NAME | ||
| # Diff: | ||
| # --- Expected | ||
| # +++ Actual | ||
| # @@ -1,2 +1,2 @@ | ||
| # -agent-* | ||
| # +agent-RELEASE-NAME |
There was a problem hiding this comment.
This seems to be a result of a merge conflict.
There was a problem hiding this comment.
Oh I was including this as the result of one of the unit tests. It actually depends what you enter as the nameOverride as to whether it counts the -RELEASE-NAME part. It caught me out as if you just use helm template --set nameOverride=agent ... then you don't see the RELEASE-NAME part. I wanted to include the output so I don't forget this subtly in the future :)
Helps to resolve #438 as it adds helm unittest to test the new features added.
Allows:
extraArgsto the agent.v1notv1beta1