Skip to content

Minor clarifications in cluster install pre-reqs#32

Merged
jetstack-bot merged 1 commit intojetstack:masterfrom
charlieegan3:update-pre-reqs
Jan 8, 2020
Merged

Minor clarifications in cluster install pre-reqs#32
jetstack-bot merged 1 commit intojetstack:masterfrom
charlieegan3:update-pre-reqs

Conversation

@charlieegan3
Copy link
Contributor

@charlieegan3 charlieegan3 commented Jan 7, 2020

No description provided.

@jetstack-bot jetstack-bot added the dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. label Jan 7, 2020
@jetstack-bot jetstack-bot requested a review from j-fuentes January 7, 2020 16:33
@jetstack-bot jetstack-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Jan 7, 2020
wwwil
wwwil reviewed Jan 8, 2020
View reviewed changes
wwwil
wwwil reviewed Jan 8, 2020
View reviewed changes
@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 8, 2020
@wwwil
Copy link
Member

wwwil commented Jan 8, 2020 •
edited
Loading

This PR closes #22

@charlieegan3
Minor clarifications in cluster install pre-reqs
3c4b97e 
Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2020
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Jan 8, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charlieegan3, j-fuentes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [charlieegan3,j-fuentes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@j-fuentes
Copy link
Member

j-fuentes commented Jan 8, 2020

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2020
@jetstack-bot jetstack-bot merged commit e4131e1 into jetstack:master Jan 8, 2020
@j-fuentes j-fuentes mentioned this pull request Jan 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wwwil wwwil wwwil left review comments

@j-fuentes j-fuentes j-fuentes approved these changes

Assignees

@j-fuentes j-fuentes

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@charlieegan3 @wwwil @jetstack-bot @j-fuentes