Add Version Checker datagatherer by charlieegan3 · Pull Request #200 · jetstack/jetstack-secure

charlieegan3 · 2020-11-02T18:16:19Z

This creates a datagatherer based on version checker. The new datagatherer wraps the dynamic client and version-checker. It returns a list of pods and the results of their image check from version checker.

Fixes https://github.com/jetstack/preflight-platform/issues/608

jetstack-bot · 2020-11-02T18:16:20Z

@charlieegan3: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jetstack-bot · 2020-11-02T18:16:21Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

This creates a datagatherer based on version checker There is still work to load the config correctly from files Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

JoshVanL

Made a couple comments, hope they make sense 😄

/assign @charlieegan3

pkg/datagatherer/versionchecker/versionchecker.go

pkg/datagatherer/versionchecker/versionchecker_test.go

JoshVanL · 2020-11-03T16:15:46Z

pkg/datagatherer/versionchecker/versionchecker_test.go

+	expectedResultsJSON := fmt.Sprintf(`[
+  {
+    "pod": {
+      "kind": "Pod",
+      "apiVersion": "v1",
+      "metadata": {
+        "name": "example-6d94489854-zpzhr",
+        "namespace": "example",
+        "selfLink": "/api/v1/namespaces/example/pods/example-6d94489854-zpzhr",
+        "uid": "efff9dae-28ca-42c3-be70-970731c44f67",
+        "resourceVersion": "32023849",
+        "creationTimestamp": null,
+        "labels": {
+          "app": "example"
+        },
+        "ownerReferences": [
+          {
+            "apiVersion": "apps/v1",
+            "kind": "ReplicaSet",
+            "name": "example-6d94489854",
+            "uid": "bb6c0f31-0e28-4c28-a81d-91b8d7bfed33",
+            "controller": true,
+            "blockOwnerDeletion": true
+          }
+        ]
+      },
+      "spec": {
+        "containers": [
+          {
+            "name": "example",
+            "image": "%s/jetstack/example:v1.0.0",
+            "command": [
+              "sh",
+              "-c"
+            ],
+            "resources": {}
+          }
+        ]
+      },
+      "status": {
+        "containerStatuses": [
+          {
+            "name": "example",
+            "state": {},
+            "lastState": {},
+            "ready": false,
+            "restartCount": 0,
+            "image": "",
+            "imageID": "is set"
+          }
+        ]
+      }
+    },
+    "result": {
+      "CurrentVersion": "v1.0.0",
+      "LatestVersion": "v1.0.1",
+      "IsLatest": false,
+      "ImageURL": "%s/jetstack/example"
+    }
+  }
+]`, parsedURL.Host, parsedURL.Host)


Maybe push the json to a const at the bottom of the file so it doesn't interrupt the flow of the code?

Call me mad, but I like this 😂

I'm going to leave this comment open in case others agree with you.

pkg/datagatherer/versionchecker/versionchecker_test.go

As per comments Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

As per feedback Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

This is needed to make the config loading from a global config file work Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

As per style feedback Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

In case files are leftover after a failed test run Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

As per feedback Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

Also shows if container is init or not. This makes the volume of data less to send to the backend Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

To match https://github.com/jetstack/cert-manager/blob/8127f0ad4228c58f37f0c0e4f5a2ef90c04f5082/pkg/controller/certificaterequests/ca/ca.go#L19, as per feedback Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

This is in order to improve vc log output Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

As per feedback Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

pkg/datagatherer/versionchecker/versionchecker.go

tfadeyi · 2020-11-04T11:01:48Z

lgtm to me 👍

Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

jetstack-bot · 2020-11-04T12:18:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charlieegan3, j-fuentes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [charlieegan3,j-fuentes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jetstack-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2020

jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 2, 2020

jetstack-bot requested a review from wwwil November 2, 2020 18:16

jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 2, 2020

charlieegan3 force-pushed the version-checker-dg branch from 580eb0b to 53cb2d4 Compare November 2, 2020 18:16

charlieegan3 added 4 commits November 3, 2020 15:20

Example version checker dg

07c260f

This creates a datagatherer based on version checker There is still work to load the config correctly from files Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

Move to correctly named folder

329acdb

Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

Tidy test and extract some functions from test

42255bd

Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

Parse version checker config

80032b7

Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

charlieegan3 force-pushed the version-checker-dg branch from 68d8c80 to 80032b7 Compare November 3, 2020 15:21

Use config loading in tests

7bd53e5

Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

charlieegan3 force-pushed the version-checker-dg branch from 3ff051e to 7bd53e5 Compare November 3, 2020 15:30

jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Nov 3, 2020

Better explain some functions, correct json output

73fa330

Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

charlieegan3 marked this pull request as ready for review November 3, 2020 15:36

jetstack-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2020

charlieegan3 changed the title ~~Example version checker dg~~ Version Checker datagatherer Nov 3, 2020

charlieegan3 changed the title ~~Version Checker datagatherer~~ Add Version Checker datagatherer Nov 3, 2020

Explain unused vc options config

a053a94

Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

JoshVanL suggested changes Nov 3, 2020

View reviewed changes

jetstack-bot assigned charlieegan3 Nov 3, 2020

charlieegan3 added 12 commits November 3, 2020 16:36

Use switch statement and w.Write

6b6ab81

As per comments Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

Use ReadFile over ReadAll

87384d2

As per feedback Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

Show registry kind in load error

578be1c

As per feedback Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

Add comment explaining array format

455d035

Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

Add versionchecker dg config to unmarshal

1d3231c

This is needed to make the config loading from a global config file work Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

Move version checker imports to new block

e25a81c

As per style feedback Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

Use more descriptive tmpfile prefix

1508c19

In case files are leftover after a failed test run Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

Use consts for config path values

93c92a5

As per feedback Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

Only return tmpfile name

c354eb7

As per feedback Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

Group all containers under pod

22023da

Also shows if container is init or not. This makes the volume of data less to send to the backend Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

Correct import grouping

25b1117

To match https://github.com/jetstack/cert-manager/blob/8127f0ad4228c58f37f0c0e4f5a2ef90c04f5082/pkg/controller/certificaterequests/ca/ca.go#L19, as per feedback Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

Use the host of the selfhosted reg as name

42cd668

This is in order to improve vc log output Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

charlieegan3 force-pushed the version-checker-dg branch from 7c6551b to 42cd668 Compare November 3, 2020 18:03

Structure config loading cases in table

f1551f8

As per feedback Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

tfadeyi reviewed Nov 4, 2020

View reviewed changes

pkg/datagatherer/versionchecker/versionchecker.go Outdated Show resolved Hide resolved

Use consts when setting values too

75a168c

Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>

j-fuentes removed the request for review from wwwil November 4, 2020 12:12

j-fuentes approved these changes Nov 4, 2020

View reviewed changes

charlieegan3 merged commit 12636ec into master Nov 4, 2020

charlieegan3 deleted the version-checker-dg branch November 4, 2020 12:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Version Checker datagatherer#200

Add Version Checker datagatherer#200
charlieegan3 merged 21 commits intomasterfrom
version-checker-dg

charlieegan3 commented Nov 2, 2020 •

edited

Loading

Uh oh!

jetstack-bot commented Nov 2, 2020

Uh oh!

jetstack-bot commented Nov 2, 2020

Uh oh!

JoshVanL left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoshVanL Nov 3, 2020

Uh oh!

charlieegan3 Nov 3, 2020 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tfadeyi commented Nov 4, 2020 •

edited

Loading

Uh oh!

jetstack-bot commented Nov 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

charlieegan3 commented Nov 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jetstack-bot commented Nov 2, 2020

Uh oh!

jetstack-bot commented Nov 2, 2020

Uh oh!

JoshVanL left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoshVanL Nov 3, 2020

Choose a reason for hiding this comment

Uh oh!

charlieegan3 Nov 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tfadeyi commented Nov 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jetstack-bot commented Nov 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

charlieegan3 commented Nov 2, 2020 •

edited

Loading

charlieegan3 Nov 3, 2020 •

edited

Loading

tfadeyi commented Nov 4, 2020 •

edited

Loading