Skip to content

Add SchemaVersion and PackageVersion to packages#17

Merged
jetstack-bot merged 1 commit intojetstack:masterfrom
j-fuentes:package-version
Dec 16, 2019
Merged

Add SchemaVersion and PackageVersion to packages#17
jetstack-bot merged 1 commit intojetstack:masterfrom
j-fuentes:package-version

Conversation

@j-fuentes
Copy link
Member

This adds SchemaVersion and PackageVersion to Preflight Packages.

SchemaVersion will be used to version different schemas of the Policy Manifest and virtually any change to the package format in general.

PackageVersion can be used to identify different versions/evolutions of the same package.

Notice the linter has been changed to enforce that the packages make use of these versions.

Signed-off-by: Jose Fuentes jsfuentescastillo@gmail.com

Signed-off-by: Jose Fuentes <jsfuentescastillo@gmail.com>
@j-fuentes j-fuentes requested a review from wwwil December 16, 2019 17:28
@j-fuentes j-fuentes self-assigned this Dec 16, 2019
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Dec 16, 2019
@jetstack-bot jetstack-bot requested a review from munnerz December 16, 2019 17:28
@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 16, 2019
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: j-fuentes, wwwil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wwwil
Copy link
Member

wwwil commented Dec 16, 2019

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2019
@jetstack-bot jetstack-bot merged commit 7a2806a into jetstack:master Dec 16, 2019
@j-fuentes j-fuentes deleted the package-version branch December 17, 2019 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants