Enhance Dockerfile adding multistage build #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! The Dockerfile is designed to work with goreleaser which we use to produce our releases. This is why it copies the binary into the container. That being said, I do think it is valuable to have a Dockerfile that you can build with |
ribbybibby
reviewed
Feb 1, 2023
ribbybibby
suggested changes
Feb 1, 2023
sergioasantiago
force-pushed
the
sergioasantiago/enhance_dockerfile
branch
from
9fcb619 to
61f5ad6
Compare
sergioasantiago
force-pushed
the
sergioasantiago/enhance_dockerfile
branch
from
61f5ad6 to
24f8da7
Compare
Thanks for your comment, Changes have been made. |
ribbybibby
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.