chore: Enable golangci-lint #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperQ
force-pushed
the
golangci-lint
branch
from
e1c28c5 to
4668e54
Compare
|
Personally, I'd separate out the implementation of the lint action and the actual changes you've made because of the linting into different commits just so the history is a bit cleaner. Your call though. |
|
Sure, I can split it. |
|
Split PR into two commits. |
|
|
SuperQ
force-pushed
the
golangci-lint
branch
from
dd1189e to
8da323d
Compare
Merged
In prep to add golangci-lint, fix various linting issues. * Make the `kvm` package a fully-qualified public package. Signed-off-by: SuperQ <superq@gmail.com>
|
Ping @ym, it would be nice to get this merged so we can keep the code tested and tidy. |
Add a GitHub actions workflow to run golangci-lint. Signed-off-by: SuperQ <superq@gmail.com>
Signed-off-by: SuperQ <superq@gmail.com>
ym
approved these changes
Mar 12, 2025
|
Thanks for all the reviews and merges! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a GitHub actions workflow to run golangci-lint.
kvmpackage a fully-qualified public package.