Skip to content

feat: add rpcCall lv_obj_add_flag and lv_obj_clear_flag #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

ym
Copy link
Contributor

@ym ym commented Apr 12, 2025

No description provided.

@ym ym requested review from chemhack and Copilot April 12, 2025 20:49
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

ctrl.c Outdated
Comment on lines 171 to 172
return 0; // Unknown flag
}
Copy link
Preview

Copilot AI Apr 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using 0 to indicate an unknown flag may be risky if a valid flag could also have a value of 0. Consider using a distinct error value or mechanism to clearly differentiate between an unknown flag and a valid flag with a value of 0.

Suggested change
return 0; // Unknown flag
}
return LV_OBJ_FLAG_UNKNOWN; // Unknown flag

Copilot uses AI. Check for mistakes.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant