Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement outdated command #2497

Merged
merged 2 commits into from
Feb 5, 2025
Merged

feat: implement outdated command #2497

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9672a6d
feat: implement outdated command
guerinoni Jan 31, 2025
c007174
fix typo
Lagoja Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat: implement outdated command 
This allow to present all new versions available for the pkg installed.
It is a lot useful because otherwise you need to check this manually.
  • Loading branch information
@guerinoni
guerinoni committed Jan 31, 2025
commit 9672a6dbfed0d3c920078ef8384f0ce9ab009837
45 changes: 45 additions & 0 deletions internal/boxcli/outdated.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
package boxcli

import (
"github.com/pkg/errors"
"github.com/spf13/cobra"
"go.jetpack.io/devbox/internal/devbox"
"go.jetpack.io/devbox/internal/devbox/devopt"
)

func outdatedCmd() *cobra.Command {
flags := listCmdFlags{}
command := &cobra.Command{
Use: "outdated",
Short: "Show all outdated packages",
Args: cobra.MaximumNArgs(0),
PreRunE: ensureNixInstalled,
RunE: func(cmd *cobra.Command, _ []string) error {
box, err := devbox.Open(&devopt.Opts{
Dir: flags.config.path,
Stderr: cmd.ErrOrStderr(),
})
if err != nil {
return errors.WithStack(err)
}

resutls, err := box.Outdated(cmd.Context())

Check warning on line 26 in internal/boxcli/outdated.go

View workflow job for this annotation

GitHub Actions / Spell Check with Typos 

"resutls" should be "results".
if err != nil {
return errors.WithStack(err)
}

if len(resutls) == 0 {

Check warning on line 31 in internal/boxcli/outdated.go

View workflow job for this annotation

GitHub Actions / Spell Check with Typos 

"resutls" should be "results".
cmd.Println("Your packages are up to date!")
return nil
}

cmd.Println("The following packages can be updated:")
for pkg, version := range resutls {

Check warning on line 37 in internal/boxcli/outdated.go

View workflow job for this annotation

GitHub Actions / Spell Check with Typos 

"resutls" should be "results".
cmd.Printf(" * %-30s %s -> %s\n", pkg, version.Current, version.Latest)
}
return nil
},
}

return command
}
1 change: 1 addition & 0 deletions internal/boxcli/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ func RootCmd() *cobra.Command {
command.AddCommand(infoCmd())
command.AddCommand(initCmd())
command.AddCommand(installCmd())
command.AddCommand(outdatedCmd())
command.AddCommand(integrateCmd())
command.AddCommand(listCmd())
command.AddCommand(logCmd())
Expand Down
43 changes: 43 additions & 0 deletions internal/devbox/packages.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import (
"go.jetpack.io/devbox/internal/devpkg"
"go.jetpack.io/devbox/internal/devpkg/pkgtype"
"go.jetpack.io/devbox/internal/lock"
"go.jetpack.io/devbox/internal/searcher"
"go.jetpack.io/devbox/internal/setup"
"go.jetpack.io/devbox/internal/shellgen"
"go.jetpack.io/devbox/internal/telemetry"
Expand All @@ -43,6 +44,48 @@ const StateOutOfDateMessage = "Your devbox environment may be out of date. Run %
// packages.go has functions for adding, removing and getting info about nix
// packages

type UpdateVersion struct {
Current string
Latest string
}

// Outdated returns a map of package names to their available latest version.
func (d *Devbox) Outdated(ctx context.Context) (map[string]UpdateVersion, error) {
ctx, task := trace.NewTask(ctx, "devboxOutdated")
defer task.End()

outdatedPackages := map[string]UpdateVersion{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, would prefer to use a slice over map. We don't need random access or deduplication.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gcurtis may not like this but we could just return []lo.Tuple2[*lockfile.Package, *lockfile.Package]

that way we don't have to create a new struct at all.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm I don't mind the struct. Its nice to have the names

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The map is just a convenience for the name. Otherwise you'd have to add a Name field to the struct. That works too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How you prefer guys, here map doesn't create any performance problems, it is just a matter of some seconds to run the command, I chose readability over little optimization


for _, pkg := range d.AllPackages() {
if strings.HasSuffix(pkg.Versioned(), "latest") {
continue
}

result, err := searcher.Client().Search(ctx, pkg.CanonicalName())
if err != nil {
return nil, err
}

for _, p := range result.Packages {
if p.Name == pkg.CanonicalName() {
for _, v := range p.Versions {
vv, err := pkg.ResolvedVersion()
if err != nil {
return nil, err
}

if v.Version > vv {
outdatedPackages[p.Name] = UpdateVersion{Current: vv, Latest: v.Version}
break
}
}
}
}
}

return outdatedPackages, nil
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guerinoni I think we need this function to be rewritten as so. I created this patch via git diff --patch, so you could try applying it: https://gist.github.com/savil/7a55e959c5eb5c5e240f57dedd5fd7ad

copying here for clarity:

type UpdateVersion struct {
	Current string
	Latest  string
}

// Outdated returns a map of package names to their available latest version.
func (d *Devbox) Outdated(ctx context.Context) (map[string]UpdateVersion, error) {
	ctx, task := trace.NewTask(ctx, "devboxOutdated")
	defer task.End()

	lockfile := d.Lockfile()
	outdatedPackages := map[string]UpdateVersion{}

	for _, pkg := range d.AllPackages() {
		// For non-devbox packages, like flakes or runx, we can skip for now
		if !pkg.IsDevboxPackage {
			continue
		}

		lockPackage, err := lockfile.FetchResolvedPackage(pkg.Versioned())
		if err != nil {
			return nil, errors.Wrap(err, "failed to fetch resolved package")
		}
		existingLockPackage := lockfile.Packages[pkg.Raw]
		if lockPackage.Version == existingLockPackage.Version {
			continue
		}

		outdatedPackages[pkg.Versioned()] = UpdateVersion{Current: existingLockPackage.Version, Latest: lockPackage.Version}
	}

	return outdatedPackages, nil
}

wdyt @gcurtis @mikeland73 ?

The benefit of this is that it also works for @latest. For example, when I run this on the devbox repo itself, I see:

$ devbox run build
$  dist/devbox ls --outdated
The following packages can be updated:
 * go@latest                      1.23.0 -> 1.23.4
 * runx:golangci/golangci-lint@latest v1.60.2 -> v1.63.4

I don't think the runx one should be getting printed, but its cause we return true for IsDevboxPackage for runx packages!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I aligned with this patch :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not runx? The versions are correct. Ideally we could also do it for flakes as well but our current flake update mechanism is a bit broken.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh good point, I forgot runx updating works properly. So all good

}

// Add adds the `pkgs` to the config (i.e. devbox.json) and nix profile for this
// devbox project
func (d *Devbox) Add(ctx context.Context, pkgsNames []string, opts devopt.AddOpts) error {
Expand Down
Loading