Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Move Caching into Equinox; remove Store -> Core deps #420

Merged
merged 4 commits into from
Aug 9, 2023

Conversation

bartelink
Copy link
Collaborator

@bartelink bartelink commented Aug 9, 2023

Only 99% sure this is for the best as:

  • it doubles the perceived lines of code in Equinox
  • major next/final step is to push out Log dependency, and maybe that's easier to do s part of feat(MessageDb): Replace logging with complete OT metrics #407 without doing this first? (Having said that, moving the Log dependency out to the stores is orthogonal to whether Caching lives in Equinox)

But ew also have some benefits:

  • if you want to understand the caching, you need to fish it out of the Async.Core pile
  • Equinox.Core now becomes a freestanding lib that a) does not depend on Equinox b) is not depended on my the Stores
  • we can now version Equinox (single thing that all stores depend on and) and Equinox.Core (grab bag of stuff that only Equinox.Core uses AsyncCacheCell out of) as independent beasts. Then one could have a store impl version and an Equinox version that vary independently. (That would be a small change to the MinVer tagging config, and would make the current NuGet upload logic fail (e.g. if you build N packages but only one is new, the upload stops at the first one in alphabetical that's a duplicate) (but we don't use it anyway atm so it's also moot))

@bartelink bartelink changed the title spike: Move Cache/Caching into Equinox feat: Move Cache/Caching into Equinox; remove Core dep from Stores Aug 9, 2023
@bartelink bartelink changed the title feat: Move Cache/Caching into Equinox; remove Core dep from Stores feat: Move Caching into Equinox; remove Store -> Core deps Aug 9, 2023
@bartelink bartelink marked this pull request as ready for review August 9, 2023 09:13
@bartelink bartelink changed the title feat: Move Caching into Equinox; remove Store -> Core deps feat!: Move Caching into Equinox; remove Store -> Core deps Aug 9, 2023
@bartelink bartelink mentioned this pull request Aug 9, 2023
@bartelink bartelink merged commit 517bd7e into master Aug 9, 2023
4 checks passed
@bartelink bartelink deleted the central-cache branch August 9, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant