Standardize store naming: Connection/Context/Category #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartelink
changed the title
bartelink
changed the title
bartelink
force-pushed
the
naming-consistency
branch
2 times, most recently
from
0c98038
to
5f9ef31
Compare
bartelink
force-pushed
the
naming-consistency
branch
from
5f9ef31
to
0d17eeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of realignment given we are entering V3 and have an opportunity to do some light breaking chances, this PR aligns the naming of top level objects with that used in
Equinox.CosmosStoreThe key changes are:
Resolverbecomes<StoreName>Category, which seems to work wellEquinox.EventStore.ContextbecomesEquinox.EventStore.EventStoreContext. This convention is established by the Azure.Core SDK guidelines and will flow to theAzure.CosmosV4 SDK in due course (i.e.Microsoft.Azure.Cosmos.Clientwill becomeAzure.Cosmos.CosmosClientetc)renamereverted - better to reserve the term<StoreName>Connectionto<StoreName>Client(had been considering leaving it at Connection but EventStoreDB's GRPC client follows that naming too so it all makes sense now)Clientfor the actual ESDB or Cosmos Client, and have<StoreName>Connectionbe the wrapper for it.