Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional skipSslCheck flag to Equinox.Cosmos.Connector #170

Merged
merged 3 commits into from
Oct 17, 2019
Merged

Optional skipSslCheck flag to Equinox.Cosmos.Connector #170

merged 3 commits into from
Oct 17, 2019

Conversation

Kelvin4702
Copy link
Contributor

@Kelvin4702 Kelvin4702 commented Oct 16, 2019

The CosmosDB emulator uses a self-signed certificate that is issued only to localhost by default. In order to use the emulator from a Docker container, one must either

  1. generate a new certificate with the respective alternate subject names, export it, then install it into the Docker image,
  2. or override the default handler in the DocumentClient to skip SSL verification

This change provides a flag for using option 2.

Context: https://docs.microsoft.com/en-us/azure/cosmos-db/local-emulator#running-on-mac-or-linux
This might no longer be required if/when there is a Linux Docker image available for the emulator.

The CosmosDB emulator uses a self-signed certificate that is issued only to `localhost` by default. In order to use the emulator from a Docker container, one must either
1) generate a new certificate with the respective alternate subject names, export it, then install it into the Docker image,
2) or override the default handler in the DocumentClient to skip SSL verification

This change provides a flag for using option 2.
@CLAassistant
Copy link

CLAassistant commented Oct 16, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@bartelink bartelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good; appreciate the efforts you've gone to to keep it minimal
some uber picky style suggestions attached ;)
I'm happy to just merge and apply the changes my side if you don't have a gap right now

src/Equinox.Cosmos/Equinox.Cosmos.fsproj Show resolved Hide resolved
src/Equinox.Cosmos/Cosmos.fs Show resolved Hide resolved
src/Equinox.Cosmos/Cosmos.fs Show resolved Hide resolved
@bartelink
Copy link
Collaborator

@enricosada this PR proposes to up the DocDb client ver to 2.2.0 (from 2.0.0)
Equinox once had a 2.2.x dependency (in ~ 1.0.2) - is upping the requirement a significant problem warranting publishing of this as a beta package or do we feel overriding to 2.2 is The Right Thing To Do?

@bartelink
Copy link
Collaborator

Thanks! As agreed out of band, I'll apply the tweaks above separately

@bartelink bartelink merged commit fd85759 into jet:master Oct 17, 2019
bartelink added a commit that referenced this pull request Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants