Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace single RenderedEvent with RenderedSpan in Projection Codec lib #131

Merged
merged 4 commits into from
May 16, 2019

Conversation

bartelink
Copy link
Collaborator

Due to the nature of Kafka's [lack] of ordering guarantees, this PR adjusts the primary event encoding used when we feed to Kafka.

While there is an arguable benefit to retaining the earlier RenderedEvent type in situ, for clarity I'm removing it until such time as someone gets as far as deciding they absolutely need such an encoding in production, given the degree to which this will reduce throughput if ordering guarantees are to be preserved.

In other words, while I wouldn't completely rule out its return, on balance it feels more valuable to have a single unambiguous rendering, even if that might impose some complexity in some use cases.

This PR also removes an ill-thought-thru dependency on Equinox.Projection which is easy to avoid and means consumers don't depend on the projection library

@bartelink bartelink merged commit 8ee2d99 into master May 16, 2019
@bartelink bartelink deleted the renderedspan branch May 16, 2019 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant