Replace single RenderedEvent with RenderedSpan in Projection Codec lib #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the nature of Kafka's [lack] of ordering guarantees, this PR adjusts the primary event encoding used when we feed to Kafka.
While there is an arguable benefit to retaining the earlier
RenderedEvent
type in situ, for clarity I'm removing it until such time as someone gets as far as deciding they absolutely need such an encoding in production, given the degree to which this will reduce throughput if ordering guarantees are to be preserved.In other words, while I wouldn't completely rule out its return, on balance it feels more valuable to have a single unambiguous rendering, even if that might impose some complexity in some use cases.
This PR also removes an ill-thought-thru dependency on
Equinox.Projection
which is easy to avoid and means consumers don't depend on the projection library