Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a bug with crowdin-cli tool and yarn command not inheriting environment variables. #3383

Merged
merged 1 commit into from
Apr 27, 2017
Merged

Conversation

ericnakagawa
Copy link
Contributor

On last master build, crowdin-cli could not access the ENV variable CROWDIN_API_KEY. I was able to workaround this by replacing the two yarn commands ("yarn crowdin-upload" and "yarn crowdin-download") in circle.yml with their full commands.

@cpojer cpojer merged commit e1c279c into jestjs:master Apr 27, 2017
@cpojer
Copy link
Member

cpojer commented Apr 27, 2017

Let's see if this one works.

@codecov-io
Copy link

Codecov Report

Merging #3383 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3383   +/-   ##
=======================================
  Coverage   64.11%   64.11%           
=======================================
  Files         176      176           
  Lines        6530     6530           
  Branches        4        4           
=======================================
  Hits         4187     4187           
  Misses       2342     2342           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a68cb6...a1a1b91. Read the comment docs.

@ericnakagawa
Copy link
Contributor Author

Ok, I'm going to rearrange the circle.yml and have the build step run in the next PR, versus master. I'll give you a heads up once all changes are made so that it succeeds.

tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants