Highlight whitespace in expected/received #2674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const printReceived = (object: any) => RECEIVED_COLOR(stringify(object)); | ||
| const printExpected = (value: any) => EXPECTED_COLOR(stringify(value)); | ||
| const highlightTrailingWhitespace = (text: string, bgColor: Function): string => | ||
| text.split('\n') |
Contributor
There was a problem hiding this comment.
instead of splitting and joining after mapping, you can just use a global, multiline regular expression:
text.replace(/\s+$/gm, bgColor('$&'))
Contributor
Author
There was a problem hiding this comment.
I'm a dummy, thanks!
Current coverage is 68.31% (diff: 83.33%)@@ master #2674 diff @@
==========================================
Files 140 140
Lines 5059 5063 +4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 3456 3459 +3
- Misses 1603 1604 +1
Partials 0 0
|
skovhus
pushed a commit
to skovhus/jest
that referenced
this pull request
Apr 29, 2017
* Highlight whitespace in expected/received * Simplify text replacement with multiline regexp
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
* Highlight whitespace in expected/received * Simplify text replacement with multiline regexp
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2673
Test plan
I may want to add a test for this