chore: update ESLint to v9 #15531
Merged
chore: update ESLint to v9 #15531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
fisker
commented
Mar 3, 2025
| @@ -125,7 +125,7 @@ export default abstract class WorkerAbstract | |||
| * killed off. | |||
| */ | |||
| protected _shutdown(): void { | |||
| this.state === WorkerStates.SHUT_DOWN; | |||
| this.state = WorkerStates.SHUT_DOWN; | |||
There was a problem hiding this comment.
This one looks like a mistake.
There was a problem hiding this comment.
Turns out change to = will cause test failue, I'll leave it alone
https://github.com/jestjs/jest/actions/runs/13658744730/job/38184583400#step:7:61
|
Didn't know there is another lint script, will work on it later. |
fisker
commented
Mar 4, 2025
|
wow, thanks for working on this! I'll take a look tomorrow 👍 |
SimenB
approved these changes
Mar 5, 2025
| { | ||
| languageOptions: { | ||
| parserOptions: { | ||
| EXPERIMENTAL_useProjectService: true, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan