fix: pass modulePath instead of moduleName to onGenerateMock callback (#15429) #15482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for jestjs failed.
|
MillerSvt
force-pushed
the
jest-on-mock-hook
branch
from
199538e to
c557af1
Compare
12 tasks
Contributor
Author
|
@SimenB How long do you plan to view this PR? Could you tell me when we can expect it to be released? |
MillerSvt
force-pushed
the
jest-on-mock-hook
branch
from
c557af1 to
a782460
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is no way to require the actual module for the currently mocked module inside the onGenerateMock callback. I think it would be better to replace the relative module name with the absolute module path.