Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest-config): support collectCoverage in project config #15318

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

munirapp
Copy link

Background

Since collectCoverageFrom, coverageDirectory, coveragePathIgnorePatterns and coverageReporters has been added into InitialProjectOptions, it's also necessary to add collectCoverage in project options because this option is getting used for enable/disable coverage process.

This patch will fix some issues about collectCoverage warning message :

Notes

I running this command below to pass the e2e test following @SimenB instructions here

yarn jest logDebugMessages ScriptTransformer showConfig -u

Copy link

linux-foundation-easycla bot commented Sep 22, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Sep 22, 2024

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1cd0e9e
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/6721731c00161f000861ffd5
😎 Deploy Preview https://deploy-preview-15318--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@munirapp munirapp changed the title fix: support collectCoverage in project config fix(jest-config): support collectCoverage in project config Sep 22, 2024
@munirapp
Copy link
Author

munirapp commented Oct 7, 2024

Hello @SimenB sorry to distrupt you here, just want to confirm with this PR, Are jest contributors having different plan to solve this issue? if yes, then I will close this PR. But if it not, would you add some comment to elaborate what's wrong with this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant