-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
fix type of testFailureExitCode config option
#15232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for jestjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
That's just because all CLI arguments are strings. But we probably don't need to say that in the types, so real fix is probably to remove it from there? |
that sounds more reasonable but it will be breaking for those who are already passing string? |
testFailureExitCode config option can also take string valuestestFailureExitCode config option
testFailureExitCode config optiontestFailureExitCode config option
|
I doubt anybody's passing it, but if they do, it should be easy enough to change. This only changes the types anyways. Mind adding a changelog entry? |
SimenB
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
According to types
testFailureExitCodecan also take string values.Test plan
Green CI