fix: make leak-detector more aggressive when running GC #14526
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -48,6 +48,17 @@ export default class LeakDetector { | |||
| await tick(); | |||
| } | |||
|
|
|||
| if (this._isReferenceBeingHeld) { | |||
There was a problem hiding this comment.
this adds a full 300ms to the runtime of the simplest test I can manage (on a beefy macbook pro). But doing it here means we only have the hit if we believe we're still leaking after running GC, so I think it's worthwhile
There was a problem hiding this comment.
this added a lot of time to the unit tests - promising 😅 (so I ended up mocking out the call)
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Ref nodejs/node#48510 (comment)
Test plan
Green CI