Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: don't perform V8 instrumenting if !collectCoverage #13282

Merged
merged 3 commits into from
Oct 8, 2022
Merged

perf: don't perform V8 instrumenting if !collectCoverage #13282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8e5994
Don't perform V8 instrumenting if !collectCoverage
mitchhentgesspotify Sep 19, 2022
60e10d6
Update CHANGELOG.md
mitchhentgesspotify Sep 28, 2022
4636e69
Merge branch 'main' into v8-coverage-perf
SimenB Oct 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@

### Performance

- `[jest-runner]` Do not instrument v8 coverage data if coverage should not be collected [#13282](https://github.com/facebook/jest/pull/13282)

## 29.1.2

### Fixes
Expand Down
1 change: 1 addition & 0 deletions packages/jest-runner/src/runTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,7 @@ async function runTestInternal(

// if we don't have `getVmContext` on the env skip coverage
const collectV8Coverage =
globalConfig.collectCoverage &&
globalConfig.coverageProvider === 'v8' &&
typeof environment.getVmContext === 'function';

Expand Down