-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct instanceof
for ModernFakeTimers
and LegacyFakeTimers
methods
#11946
Conversation
Hi @minijus! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Codecov Report
@@ Coverage Diff @@
## main #11946 +/- ##
==========================================
- Coverage 68.77% 68.76% -0.01%
==========================================
Files 322 322
Lines 16620 16620
Branches 4795 4795
==========================================
- Hits 11430 11429 -1
- Misses 5158 5159 +1
Partials 32 32
Continue to review full report at Codecov.
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
1 similar comment
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@SimenB would you have some time to have a look into this PR? |
Hello @minijus |
Hi @joselcvarela, I am blocked as well, had to lock version on |
…ernFakeTimers and LegacyFakeTimers methods Closes jestjs#11660 jestjs#11767 jestjs#11662
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
instanceof
for ModernFakeTimers
and LegacyFakeTimers
methods
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Closes #11660
Closes #11767
Closes #11662
Summary
Solves:
Test plan
All existing tests should pass.