Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: alphabetize cli options #11586

Merged
merged 4 commits into from
Nov 29, 2021
Merged

Conversation

bdefore
Copy link
Contributor

@bdefore bdefore commented Jun 17, 2021

Summary

CLI options in documentation are not alphabetized properly. This PR reorders them and otherwise does not modify content.

Test plan

Ran yarn build but failed at 'Building TypeScript definition files' which would appear to be unrelated.

@facebook-github-bot
Copy link
Contributor

Hi @bdefore!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@bdefore
Copy link
Contributor Author

bdefore commented Jun 17, 2021

The CLA fails to submit. I've emailed cla@fb.com.

@bdefore
Copy link
Contributor Author

bdefore commented Jun 21, 2021

Was able to submit CLA fine this morning with same inputs. 🤷

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! could you update the versioned docs as well?

image

@SimenB
Copy link
Member

SimenB commented Sep 29, 2021

@bdefore ping 🙂

@bdefore bdefore requested a review from SimenB November 19, 2021 16:38
@bdefore
Copy link
Contributor Author

bdefore commented Nov 19, 2021

@SimenB sorry for the delay on this. i've merged in master and made the analogous changes to older CLI docs. to my eye this looks good, but re-requesting your review since it touches more files.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks for doing this!

@SimenB SimenB changed the title alphabetize cli options docs: alphabetize cli options Nov 29, 2021
@SimenB SimenB merged commit 7039cb1 into jestjs:main Nov 29, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants