Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add GH Action to lock older closed issues and PRs #11343

Merged
merged 2 commits into from
May 10, 2021
Merged

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Apr 26, 2021

Summary

We have issues managing the issue tracker

image

Personally, a part of that is that notifications on really old issues pile up. I currently have over 500 unread notifications from this repo, and looking at the first 25, 6 of them are in closed issues/PRs, and the next 25 there are 8. I hope that by locking old threads there will be less noise and possibly easier to stay on top of issues as the (draining) distraction of comments on issues that have sometimes been closed for many years bubble up. Inbox zero is probably not realistic either way, but at least the hope is that new issues will also include full reproductions etc instead of a relatively common "this is still an issue"

I considered GH discussions but

  1. I don't have access to enabling it
  2. I'd probably still get notifications? I don't want to create an expectation that we'll answer Qs there instead
  3. StackOverflow/Discord works pretty good?

Test plan

🤷

issue-lock-comment: >
This issue has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include the SO/discord link?

Something about linking back to relevant issues?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think make sense. I’ve noticed that it’s hard to find SO/Discord links unless going to online doc and scroll to footer. It’s better to make those links are more visible.

@codecov-commenter
Copy link

Codecov Report

Merging #11343 (cbcfd2d) into master (64d5983) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11343      +/-   ##
==========================================
- Coverage   64.16%   64.15%   -0.02%     
==========================================
  Files         308      308              
  Lines       13515    13515              
  Branches     3294     3294              
==========================================
- Hits         8672     8670       -2     
- Misses       4129     4130       +1     
- Partials      714      715       +1     
Impacted Files Coverage Δ
packages/expect/src/utils.ts 94.83% <0.00%> (-1.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64d5983...cbcfd2d. Read the comment docs.

@jeysal
Copy link
Contributor

jeysal commented Apr 26, 2021

Yeah, no one likes these bots but it doesn't help, the current situation isn't productive either.
But do I understand correctly that this only locks closed issues/PRs? That doesn't help too much with the 1000000 open issues

@SimenB
Copy link
Member Author

SimenB commented Apr 26, 2021

It will only touch closed/merged issues & PRs, yes.

And no, it won't help with the current open issues, but my thoughts process will not be "25% of my notifications are about closed issues, usually 80% of those comments are only vaguely related or +1s, I'll just not touch any notifications at all"


Please note this issue tracker is not a help forum. We recommend using [StackOverflow](https://stackoverflow.com/questions/tagged/jestjs) or our [discord channel](https://discord.gg/j6FKKQQrW9) for questions.


Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue-lock-comment: >
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Please note this issue tracker is not a help forum. We recommend using [StackOverflow](https://stackoverflow.com/questions/tagged/jestjs) or our [discord channel](https://discord.gg/j6FKKQQrW9) for questions.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added this as-is. Not sure if it should be "usage questions" or something? Also, if the docs for some feature/bug fix are bad, that's perfectly fine to open a new issue about, I don't want to discourage that

@SimenB
Copy link
Member Author

SimenB commented Apr 29, 2021

image

These are my 3 latest notifications (there was a PR in there I reviewed, but still 3/4). 2 new activities was "+1" and the last one was a helpful comment, but that slides into the "this issue tracker is not a help forum" thing.

So I still want to do this 😀 Any objections beyond "bots suck"? Which is super valid, but the lesser of two evils, IMO.

@SimenB SimenB merged commit c28e485 into master May 10, 2021
@SimenB SimenB deleted the SimenB-patch-1 branch May 10, 2021 20:29
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants