Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(worker): downgrade minimum required node version to 10.13 #10352

Merged
merged 2 commits into from
Aug 2, 2020
Merged

fix(worker): downgrade minimum required node version to 10.13 #10352

merged 2 commits into from
Aug 2, 2020

Conversation

nonewcode
Copy link
Contributor

@nonewcode nonewcode commented Aug 1, 2020

Summary

Fixes #10142
Closes #10145

Change requested to downgrade the minimum required version of node to 10.13 to solve an issue people were experiencing when using the jest-worker as a dependency

Signed-off-by: Josh Kelly <josh@codecog.dev>
@nonewcode nonewcode marked this pull request as draft August 1, 2020 19:55
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages/jest-worker/package.json Outdated Show resolved Hide resolved
An exception needs to be added against the assertion of the node engine version for sub packages. jest-worker requires a lower version than root and the current assertion fails the build.

Signed-off-by: Josh Kelly <josh@codecog.dev>
@nonewcode nonewcode marked this pull request as ready for review August 1, 2020 23:40
@nonewcode nonewcode requested a review from SimenB August 1, 2020 23:40
@SimenB SimenB merged commit 321838f into jestjs:master Aug 2, 2020
@nonewcode nonewcode deleted the jest-worker branch August 2, 2020 14:38
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change required node version for jest-worker to 10.13
3 participants