Coverage in HTML view is broken

[adyz]

🐛 Bug Report

To Reproduce

Steps to reproduce the behavior: (same as: https://jestjs.io/docs/en/getting-started)

• Create a new folder
• Init a new npm project with npm init
• Add Jest as a dependency npm install --save-dev jest
• Created a src folder with a main.js file and a main.spec.js test file (one containing sum function and the other the tests as in the Jest docs)
• Added a test script in package.json.
• Run the script with npm test -- --coverage
• When opening the coverage/lcov-report/index.html the HTML does not show the coverage report numbers.

GIT repo here: https://github.com/adyz/jest-coverage-bug-no-ts

Expected behavior

The coverage/lcov-report/index.html should show the actual report numbers

Link to repl or repo (highly encouraged)

https://github.com/adyz/jest-coverage-bug-no-ts

envinfo

npx: installed 1 in 1.36s

  System:
    OS: macOS 10.15.2
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
  Binaries:
    Node: 13.6.0 - /usr/local/bin/node
    Yarn: 1.12.3 - ~/.yarn/bin/yarn
    npm: 6.13.4 - /usr/local/bin/npm
  npmPackages:
    jest: ^24.9.0 => 24.9.0 

Let me know if I should send this to the istanbul.js as well or just there. Not sure where to go from here.
I've also noticed that on old projects the report is fine until I remove the node_modules and reinstall.

Thanks a ton!

[SimenB]

This seems like a bug in istanbul somewhere, as the text reporter works correctly.

@coreyfarrell have you seen this before?

Note that it works correctly on Jest master (which is using the new major of istanbul deps)

[SimenB]

#9389 (comment)

diff --git i/package-lock.json w/package-lock.json
index 4ae4388..9e5ba91 100644
--- i/package-lock.json
+++ w/package-lock.json
@@ -2186,9 +2186,9 @@
       "dev": true
     },
     "handlebars": {
-      "version": "4.6.0",
-      "resolved": "https://registry.npmjs.org/handlebars/-/handlebars-4.6.0.tgz",
-      "integrity": "sha512-i1ZUP7Qp2JdkMaFon2a+b0m5geE8Z4ZTLaGkgrObkEd+OkUKyRbRWw4KxuFCoHfdETSY1yf9/574eVoNSiK7pw==",
+      "version": "4.5.3",
+      "resolved": "https://registry.npmjs.org/handlebars/-/handlebars-4.5.3.tgz",
+      "integrity": "sha512-3yPecJoJHK/4c6aZhSvxOyG4vJKDshV36VHp0iVCDVh7o9w2vwi3NSnL2MMPj3YdduqaBcu7cGbggJQM0br9xA==",
       "dev": true,
       "requires": {
         "neo-async": "^2.6.0",
diff --git i/package.json w/package.json
index 901fec3..2971de5 100644
--- i/package.json
+++ w/package.json
@@ -9,6 +9,7 @@
   "author": "",
   "license": "ISC",
   "devDependencies": {
+    "handlebars": "~4.5.3",
     "jest": "^24.9.0"
   }
 }

[SimenB]

I've quickly opened up handlebars-lang/handlebars.js#1636 upstream linking back to this issue for the reproduction

[coreyfarrell]

I've pushed the latest-2.x branch to https://github.com/istanbuljs/istanbuljs with a cherry-pick of the handlebars removal patch.

Publishing this to npm is difficult for me as it's not possible to publish under the npm next tag, istanbul-reports@3.0.0 is already latest so any 2.x backport will automatically be available in production.

I'd appreciate anyone who has the time to manually test my patch. Due to istanbul-reports being in a monorepo it's not possible to have npm install directly from git, the following process must be followed:

• git clone https:/github.com/istanbuljs/istanbuljs
• git checkout latest-2.x
• cd istanbuljs/packages/istanbul-reports
• npm pack
• add "istanbul-reports": "file:absolute/path/to/istanbul-reports-2.2.5.tgz" to the dependencies of your project
• do what is necessary to ensure istanbul-reports from the tarball is the only version installed in your project (npm ls handlebars should not show it being installed by istanbul-reports)
• test your project, verify that HTML reports work

I've done this already with the self-tests of nyc@14.1.1 and it seemed to work but I'd like to get some confirmation before I can publish this fix to npm.

[adyz]

Hi @coreyfarrell,

I've followed your steps it seems to work well with the repo posted on this issue: https://github.com/adyz/jest-coverage-bug-no-ts

• added the generated tgz file (generated following your steps) in package.json"istanbul-reports": "file:../test-istanbul/istanbuljs/packages/istanbul-reports/istanbul-reports-2.2.5.tgz"
• removed package-lock.json and node_modules
• ran npm install again
• ran npm npm test -- --coverage and the HTML looks fine now

Thanks a ton!