Skip to content

"yarn test" in master branch fails on new installation #9015

Closed
@psytechno604

Description

🐛 Bug Report

I just wanted to contribute. Followed the guide, and got:

> yarn test
yarn run v1.19.0
$ yarn lint && yarn jest
$ eslint . --cache --report-unused-disable-directives --ext js,jsx,ts,tsx,md

/Users/sergey/Documents/opensource/jest/packages/jest-haste-map/src/lib/FSEventsWatcher.ts
  14:1  error  Unused eslint-disable directive (no problems were reported)

✖ 1 problem (1 error, 0 warnings)

To make sure that it is not my fault, I repeated the same with other system, and got:

> yarn test
yarn run v1.19.0
$ yarn lint && yarn jest
$ eslint . --cache --report-unused-disable-directives --ext js,jsx,ts,tsx,md

/home/plazmer/Documents/jest/packages/jest-worker/src/workers/NodeThreadsWorker.ts
  11:1  error  Unused eslint-disable directive (no problems were reported from 'import/no-unresolved')

/home/plazmer/Documents/jest/packages/jest-worker/src/workers/threadChild.ts
  9:1  error  Unused eslint-disable directive (no problems were reported from 'import/no-unresolved')

✖ 2 problems (2 errors, 0 warnings)

So, as we can see, errors occur in different files, but in both cases they are linked to eslint. Maybe need to use specific version? Again - I did not made any changes in both cases, strictly following the given scenario.

To Reproduce

Steps to reproduce the behavior:
Just follow this guide from scratch - https://github.com/facebook/jest/blob/master/CONTRIBUTING.md

(I did this on two different systems and got eslint errors in both cases)

Expected behavior

"yarn test" should work without errors.

envinfo

  1. System:
    OS: macOS 10.14.6
    CPU: (8) x64 Intel(R) Core(TM) i5-8279U CPU @ 2.40GHz
    Binaries:
    Node: 10.16.3 - /usr/local/bin/node
    Yarn: 1.19.0 - /usr/local/bin/yarn
    npm: 6.9.0 - /usr/local/bin/npm

  2. System:
    OS: Linux 4.15 Ubuntu 16.04.6 LTS (Xenial Xerus)
    CPU: (1) x64 Intel(R) Core(TM) i5-6300HQ CPU @ 2.30GHz
    Binaries:
    Node: 11.14.0 - /usr/bin/node
    Yarn: 1.19.0 - /usr/bin/yarn
    npm: 6.9.2 - /usr/bin/npm

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions