AppVeyor doesn't run eslint

[chadius-maximus]

What is the current behavior?

AppVeyor build doesn't run eslint, which is misleading in cases where eslint causes failures. Currently, if a build fails because of eslint (exactly what's happening right now), AppVeyor will be reporting builds as success.

What is the expected behavior?
AppVeyor build should run eslint.

[nickserv]

It's probably intentional that eslint only runs on Travis since it's supposed to be platform agnostic and that would just be duplicating work on AppVeyor. Are you experiencing a Windows specific eslint issue that isn't on the broken Travis build currently?

[chadius-maximus]

Not sure if it is Windows specific, but it is indeed occurring on Windows.

[nickserv]

Ah, I remember seeing your issue on Reactiflux. If I were you, I'd rename this issue to reflect your unique eslint error on Windows rather than AppVeyor (though enabling eslint on AppVeyor could help detect this sort of issue in the future when the eslint build is fixed).

Also you're using Jest's master branch, right? What if you checkout the latest stable release instead (or at least the last build that's passing on CI) before running eslint?

[chadius-maximus]

Also you're using Jest's master branch, right?

Yep, freshly cloned branch from master.

What if you checkout the latest stable release instead (or at least the last build that's passing on CI) before running eslint?

I could, however, I am trying to help on an already-pending PR, and (correct me if I am wrong here) that requires master branch to work.

[nickserv]

GitHub PRs technically don't need to be based off master though maintainers may prefer or require it. I would try it at least as a troubleshooting step, if it works when basing off an earlier branch you might be able to track down which change broke this on Windows. Alternately you can use something like Windows Subsystem Linux for windows 10, a remote Linux dev machine, or a local VM with hyper v.

[thymikee]

This is on purpose, to speed up AppVeyor builds as much as possible. ESLint is platform agnostic, and we happily assume that it gives the same results under both Windows and Unix systems. If something is failing for you on Windows, and not on Linux, it's a ESLint bug.

[thymikee]

cc @cpojer please decide whether we need to run eslint on windows or not (I prefer not)

[cpojer]

yeah, I'm fine without it.