`toHaveBeenCalledWith` `objectContaining` issue after patch update 26.6.1

[scagood]

🐛 Bug Report

Tests that contain Buffers in expect.objectContaining calls started failing after a patch version update.

To Reproduce

A private repo received a dependabot PR for the following update: Bump jest from 26.6.0 to 26.6.1

Previously this test would have passed:

test('issue demo', async () => {
    const func = jest.fn();

    func({ test: Buffer.from('test'), some: 'thing' });

    expect(func).toHaveBeenCalledWith(
        expect.objectContaining({ test: Buffer.from('test') }),
    );
});

That test now throws:

   TypeError: Cannot set property parent of [object Object] which has only a getter

     4 |     func({ test: Buffer.from('test'), some: 'thing' });
     5 |
   > 6 |     expect(func).toHaveBeenCalledWith(
       |                  ^
     7 |         expect.objectContaining({ test: Buffer.from('test') }),
     8 |     );
     9 | });

     at Object.<anonymous> (buffer-issue.test.js:6:18)

Expected behavior

Tests to not start failing after a patch update 😅

envinfo

Before:

 $ npx envinfo --preset jest
npx: installed 1 in 0.642s

  System:
    OS: Linux 5.3 Ubuntu 19.10 (Eoan Ermine)
    CPU: (24) x64 AMD Ryzen Threadripper 2920X 12-Core Processor
  Binaries:
    Node: 12.19.0 - ~/.nvm/versions/node/v12.19.0/bin/node
    Yarn: 1.22.5 - /usr/bin/yarn
    npm: 6.14.8 - ~/.nvm/versions/node/v12.19.0/bin/npm
  npmPackages:
    jest: ^26.5.3 => 26.6.0 

After:

 $ npx envinfo --preset jest
npx: installed 1 in 0.681s

  System:
    OS: Linux 5.3 Ubuntu 19.10 (Eoan Ermine)
    CPU: (24) x64 AMD Ryzen Threadripper 2920X 12-Core Processor
  Binaries:
    Node: 12.19.0 - ~/.nvm/versions/node/v12.19.0/bin/node
    Yarn: 1.22.5 - /usr/bin/yarn
    npm: 6.14.8 - ~/.nvm/versions/node/v12.19.0/bin/npm
  npmPackages:
    jest: ^26.5.3 => 26.6.1 

[SimenB]

I think this is a duplicate of #10689. Can you attempt to apply the fix from #10711 and see if it fixes it?

[scagood]

Thanks for the speedy response!
I updated the built package to match

But alas this does not seem to have fixed it

$ npx jest --no-coverage buffer-issue.test.js
 FAIL  ./buffer-issue.test.js
  ✕ issue demo (5 ms)

  ● issue demo

    expect(jest.fn()).toHaveBeenCalledWith(...expected)

    Expected: ObjectContaining {"test": {"data": [116, 101, 115, 116], "type": "Buffer"}}
    Received: {"some": "thing", "test": {"data": [116, 101, 115, 116], "type": "Buffer"}}

    Number of calls: 1

      4 |     func({ test: Buffer.from('test'), some: 'thing' });
      5 | 
    > 6 |     expect(func).toHaveBeenCalledWith(
        |                  ^
      7 |         expect.objectContaining({ test: Buffer.from('test') }),
      8 |     );
      9 | });

      at Object.<anonymous> (buffer-issue.test.js:6:18)

Test Suites: 1 failed, 1 total
Tests:       1 failed, 1 total
Snapshots:   0 total
Time:        0.632 s, estimated 1 s
Ran all test suites matching /buffer-issue.test.js/i.

[SimenB]

Right, so the weird error is gone, but the assertion doesn't work anymore. We should fix that!

/cc @jeysal @ninevra

[scagood]

Would the solution here be something along the lines of only recursively check objects and arrays that are vanilla objects/arrays?

I'm not 100% sure on the best way to even do that, this is what I came up with:

const expected =
  typeof this.sample[property] === 'object' &&
  (
    Object.getPrototypeOf(this.sample[property]) === Object.prototype ||
    Object.getPrototypeOf(this.sample[property]) === Array.prototype
  )
    ? objectContaining(this.sample[property] as Record<string, unknown>)
    : this.sample[property];

[SimenB]

If that passes the tests I'm happy 🙂 Send a PR?

If it doesn't work we might have to revert #10508