chore: prefer Date.now (#14811)

jestjs · Dec 29, 2023 · fb647d5 · fb647d5
1 parent da0701b
commit fb647d5
Show file tree

Hide file tree

Showing 6 changed files with 23 additions and 12 deletions.
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -439,6 +439,19 @@ module.exports = {
         'unicorn/prefer-top-level-await': 'error',
       },
     },
+    {
+      files: [
+        'e2e/coverage-report/__mocks__/sumDependency.js',
+        'e2e/require-main-after-create-require/empty.js',
+        'packages/create-jest/src/__tests__/__fixtures__/**/*',
+        'packages/jest-core/src/__tests__/**/*',
+        'packages/jest-haste-map/src/__tests__/test_dotfiles_root/**/*',
+        'packages/jest-resolve/src/__mocks__/**/*',
+      ],
+      rules: {
+        'unicorn/no-empty-file': 'off',
+      },
+    },
   ],
   parser: '@typescript-eslint/parser',
   parserOptions: {
@@ -690,13 +703,11 @@ module.exports = {
     'unicorn/error-message': 'off',
     'unicorn/no-await-expression-member': 'off',
     'unicorn/no-console-spaces': 'off',
-    'unicorn/no-empty-file': 'off',
     'unicorn/no-object-as-default-parameter': 'off',
     'unicorn/no-thenable': 'off',
     'unicorn/no-typeof-undefined': 'off',
     'unicorn/no-useless-promise-resolve-reject': 'off',
     'unicorn/no-useless-undefined': 'off',
-    'unicorn/prefer-date-now': 'off',
     'unicorn/prefer-logical-operator-over-ternary': 'off',
     'unicorn/prefer-math-trunc': 'off',
     'unicorn/prefer-native-coercion-functions': 'off',

diff --git a/e2e/__tests__/__snapshots__/testRetries.test.ts.snap b/e2e/__tests__/__snapshots__/testRetries.test.ts.snap
@@ -46,7 +46,7 @@ exports[`Test Retries wait before retry 1`] = `
 
     Received: true
 
-      15 |     expect(new Date().getTime() - startTimeInSeconds).toBeGreaterThan(200);
+      15 |     expect(Date.now() - startTimeInSeconds).toBeGreaterThan(200);
       16 |   } else {
     > 17 |     expect(true).toBeFalsy();
          |                  ^
@@ -62,7 +62,7 @@ exports[`Test Retries wait before retry 1`] = `
 
     Received: true
 
-      15 |     expect(new Date().getTime() - startTimeInSeconds).toBeGreaterThan(200);
+      15 |     expect(Date.now() - startTimeInSeconds).toBeGreaterThan(200);
       16 |   } else {
     > 17 |     expect(true).toBeFalsy();
          |                  ^
@@ -84,7 +84,7 @@ exports[`Test Retries wait before retry with fake timers 1`] = `
 
     Received: true
 
-      16 |     expect(new Date().getTime() - startTimeInSeconds).toBeGreaterThan(200);
+      16 |     expect(Date.now() - startTimeInSeconds).toBeGreaterThan(200);
       17 |   } else {
     > 18 |     expect(true).toBeFalsy();
          |                  ^
@@ -100,7 +100,7 @@ exports[`Test Retries wait before retry with fake timers 1`] = `
 
     Received: true
 
-      16 |     expect(new Date().getTime() - startTimeInSeconds).toBeGreaterThan(200);
+      16 |     expect(Date.now() - startTimeInSeconds).toBeGreaterThan(200);
       17 |   } else {
     > 18 |     expect(true).toBeFalsy();
          |                  ^

diff --git a/e2e/test-retries/__tests__/waitBeforeRetry.test.js b/e2e/test-retries/__tests__/waitBeforeRetry.test.js
@@ -7,12 +7,12 @@
 'use strict';
 
 let i = 0;
-const startTimeInSeconds = new Date().getTime();
+const startTimeInSeconds = Date.now();
 jest.retryTimes(3, {logErrorsBeforeRetry: true, waitBeforeRetry: 100});
 it('retryTimes set', () => {
   i++;
   if (i === 3) {
-    expect(new Date().getTime() - startTimeInSeconds).toBeGreaterThan(200);
+    expect(Date.now() - startTimeInSeconds).toBeGreaterThan(200);
   } else {
     expect(true).toBeFalsy();
   }

diff --git a/e2e/test-retries/__tests__/waitBeforeRetryFakeTimers.test.js b/e2e/test-retries/__tests__/waitBeforeRetryFakeTimers.test.js
@@ -7,13 +7,13 @@
 'use strict';
 
 let i = 0;
-const startTimeInSeconds = new Date().getTime();
+const startTimeInSeconds = Date.now();
 jest.retryTimes(3, {logErrorsBeforeRetry: true, waitBeforeRetry: 100});
 it('retryTimes set with fake timers', () => {
   jest.useFakeTimers();
   i++;
   if (i === 3) {
-    expect(new Date().getTime() - startTimeInSeconds).toBeGreaterThan(200);
+    expect(Date.now() - startTimeInSeconds).toBeGreaterThan(200);
   } else {
     expect(true).toBeFalsy();
     jest.runAllTimers();

diff --git a/packages/jest-console/src/CustomConsole.ts b/packages/jest-console/src/CustomConsole.ts
@@ -133,7 +133,7 @@ export default class CustomConsole extends Console {
     const startTime = this._timers[label];
 
     if (startTime != null) {
-      const endTime = new Date().getTime();
+      const endTime = Date.now();
       const time = endTime - startTime.getTime();
       this._log('time', format(`${label}: ${formatTime(time)}`));
       delete this._timers[label];

diff --git a/packages/jest-jasmine2/src/jasmine/Timer.ts b/packages/jest-jasmine2/src/jasmine/Timer.ts
@@ -31,7 +31,7 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 const defaultNow = (function (Date) {
   return function () {
-    return new Date().getTime();
+    return Date.now();
   };
 })(Date);