Skip to content

chore: make readme example config be js #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 26, 2019
Merged

chore: make readme example config be js #65

merged 2 commits into from
Jan 26, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jan 26, 2019

Relying less on string replacing rootDir is always a good thing, as that path is not necessarily true, especially in monorepos

@SimenB SimenB requested a review from thymikee January 26, 2019 18:41
thymikee
thymikee approved these changes Jan 26, 2019
View reviewed changes
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

@thymikee @SimenB
Update README.md
95f1f10 
Co-Authored-By: SimenB <sbekkhus91@gmail.com>
@thymikee thymikee merged commit 1a898ca into master Jan 26, 2019
@thymikee thymikee deleted the SimenB-patch-1 branch January 26, 2019 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thymikee thymikee thymikee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimenB @thymikee