Adjust rules #919
Merged
Adjust rules #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
add-rules-to-config-2
branch
2 times, most recently
from
54a709f
to
a86994e
Compare
SimenB
reviewed
Oct 4, 2021
Comment on lines
95
to
96
| "jest/prefer-to-be-null": "error", | ||
| "jest/prefer-to-be-undefined": "error", |
There was a problem hiding this comment.
these should be removed first (or at the same time)
There was a problem hiding this comment.
Yeah I wanted to make the PR without setting it up to conflict when #918 is merged in
BREAKING CHANGE: recommend `prefer-to-be` rule
BREAKING CHANGE: removed `prefer-to-be-null` rule
BREAKING CHANGE: removed `prefer-to-be-undefined` rule
BREAKING CHANGE: renamed `lowercase-name` to `prefer-lowercase-title`
BREAKING CHANGE: renamed `valid-describe` to `valid-describe-callback`
SimenB
force-pushed
the
add-rules-to-config-2
branch
from
58bf093
to
2fd507b
Compare
|
🎉 This PR is included in version 25.0.0-next.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 25.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: recommend
prefer-to-berule