Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(no-focused-tests): make fixable #787

Merged
merged 5 commits into from
Mar 9, 2021

Conversation

alagane
Copy link
Contributor

@alagane alagane commented Mar 8, 2021

Already marked as fixable in the README.md

@alagane alagane force-pushed the make-no-focused-tests-fixable branch from db65c75 to c35321d Compare March 9, 2021 10:32
@alagane
Copy link
Contributor Author

alagane commented Mar 9, 2021

Ready to review!

@alagane alagane requested a review from SimenB March 9, 2021 10:34
@SimenB
Copy link
Member

SimenB commented Mar 9, 2021

remove fixable: 'code' from the rule, and I think the docs generator will agree with you

@alagane alagane force-pushed the make-no-focused-tests-fixable branch from c35321d to a8b573a Compare March 9, 2021 10:52
src/rules/no-focused-tests.ts Outdated Show resolved Hide resolved
@SimenB
Copy link
Member

SimenB commented Mar 9, 2021

@alagane fyi we'll squash merge when landing, so no need to force push (it's easier to review without force pushes as we can see the changes between each commit). this PR is of course small enough that it doesn't really matter, so keep doing force pushes if it's the workflow you're most comfortable with

and as a consequence, feel free to ignore errors from commitlint (you can just do chore: change things or something for local commits)

Apply suggestion

Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
alagane and others added 2 commits March 9, 2021 12:12
Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
src/rules/no-focused-tests.ts Outdated Show resolved Hide resolved
src/rules/no-focused-tests.ts Outdated Show resolved Hide resolved
src/rules/no-focused-tests.ts Outdated Show resolved Hide resolved
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit 040871a into jest-community:main Mar 9, 2021
github-actions bot pushed a commit that referenced this pull request Mar 9, 2021
# [24.2.0](v24.1.10...v24.2.0) (2021-03-09)

### Features

* **no-focused-tests:** make fixable ([#787](#787)) ([040871a](040871a))
@github-actions
Copy link

github-actions bot commented Mar 9, 2021

🎉 This PR is included in version 24.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants