Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace eslint-plugin-node with eslint-plugin-n #1462

Merged
merged 1 commit into from
Oct 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ module.exports = {
extends: [
'plugin:eslint-plugin/recommended',
'plugin:eslint-comments/recommended',
'plugin:node/recommended',
'plugin:n/recommended',
'plugin:@typescript-eslint/eslint-recommended',
'plugin:prettier/recommended',
],
plugins: [
'eslint-plugin',
'eslint-comments',
'node',
'n',
'import',
'@typescript-eslint',
],
Expand Down Expand Up @@ -55,10 +55,10 @@ module.exports = {
'sort-imports': ['error', { ignoreDeclarationSort: true }],
'require-unicode-regexp': 'error',
// TS covers these 2
'node/no-missing-import': 'off',
'node/no-missing-require': 'off',
'node/no-unsupported-features/es-syntax': 'off',
'node/no-unsupported-features/es-builtins': 'error',
'n/no-missing-import': 'off',
'n/no-missing-require': 'off',
'n/no-unsupported-features/es-syntax': 'off',
'n/no-unsupported-features/es-builtins': 'error',
'import/no-commonjs': 'error',
'import/no-duplicates': 'error',
'import/no-extraneous-dependencies': 'error',
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@
"eslint-plugin-eslint-comments": "^3.1.2",
"eslint-plugin-eslint-plugin": "^5.0.6",
"eslint-plugin-import": "^2.25.1",
"eslint-plugin-node": "^11.0.0",
"eslint-plugin-n": "^15.0.0",
"eslint-plugin-prettier": "^5.0.0",
"eslint-remote-tester": "^3.0.0",
"eslint-remote-tester-repositories": "~1.0.0",
Expand Down
44 changes: 23 additions & 21 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3708,7 +3708,7 @@ __metadata:
languageName: node
linkType: hard

"builtins@npm:^5.0.0":
"builtins@npm:^5.0.0, builtins@npm:^5.0.1":
version: 5.0.1
resolution: "builtins@npm:5.0.1"
dependencies:
Expand Down Expand Up @@ -4996,15 +4996,15 @@ __metadata:
languageName: node
linkType: hard

"eslint-plugin-es@npm:^3.0.0":
version: 3.0.1
resolution: "eslint-plugin-es@npm:3.0.1"
"eslint-plugin-es@npm:^4.1.0":
version: 4.1.0
resolution: "eslint-plugin-es@npm:4.1.0"
dependencies:
eslint-utils: ^2.0.0
regexpp: ^3.0.0
peerDependencies:
eslint: ">=4.19.1"
checksum: e57592c52301ee8ddc296ae44216df007f3a870bcb3be8d1fbdb909a1d3a3efe3fa3785de02066f9eba1d6466b722d3eb3cc3f8b75b3cf6a1cbded31ac6298e4
checksum: 26b87a216d3625612b1d3ca8653ac8a1d261046d2a973bb0eb2759070267d2bfb0509051facdeb5ae03dc8dfb51a434be23aff7309a752ca901d637da535677f
languageName: node
linkType: hard

Expand Down Expand Up @@ -5088,7 +5088,7 @@ __metadata:
eslint-plugin-eslint-comments: ^3.1.2
eslint-plugin-eslint-plugin: ^5.0.6
eslint-plugin-import: ^2.25.1
eslint-plugin-node: ^11.0.0
eslint-plugin-n: ^15.0.0
eslint-plugin-prettier: ^5.0.0
eslint-remote-tester: ^3.0.0
eslint-remote-tester-repositories: ~1.0.0
Expand Down Expand Up @@ -5118,19 +5118,21 @@ __metadata:
languageName: unknown
linkType: soft

"eslint-plugin-node@npm:^11.0.0":
version: 11.1.0
resolution: "eslint-plugin-node@npm:11.1.0"
"eslint-plugin-n@npm:^15.0.0":
version: 15.7.0
resolution: "eslint-plugin-n@npm:15.7.0"
dependencies:
eslint-plugin-es: ^3.0.0
eslint-utils: ^2.0.0
builtins: ^5.0.1
eslint-plugin-es: ^4.1.0
eslint-utils: ^3.0.0
ignore: ^5.1.1
minimatch: ^3.0.4
resolve: ^1.10.1
semver: ^6.1.0
is-core-module: ^2.11.0
minimatch: ^3.1.2
resolve: ^1.22.1
semver: ^7.3.8
peerDependencies:
eslint: ">=5.16.0"
checksum: 5804c4f8a6e721f183ef31d46fbe3b4e1265832f352810060e0502aeac7de034df83352fc88643b19641bb2163f2587f1bd4119aff0fd21e8d98c57c450e013b
eslint: ">=7.0.0"
checksum: cfbcc67e62adf27712afdeadf13223cb9717f95d4af8442056d9d4c97a8b88af76b7969f75deaac26fa98481023d6b7c9e43a28909e7f0468f40b3024b7bcfae
languageName: node
linkType: hard

Expand Down Expand Up @@ -6539,7 +6541,7 @@ __metadata:
languageName: node
linkType: hard

"is-core-module@npm:^2.13.0, is-core-module@npm:^2.5.0, is-core-module@npm:^2.8.1":
"is-core-module@npm:^2.11.0, is-core-module@npm:^2.13.0, is-core-module@npm:^2.5.0, is-core-module@npm:^2.8.1":
version: 2.13.1
resolution: "is-core-module@npm:2.13.1"
dependencies:
Expand Down Expand Up @@ -9870,7 +9872,7 @@ __metadata:
languageName: node
linkType: hard

"resolve@npm:^1.10.0, resolve@npm:^1.10.1, resolve@npm:^1.14.2, resolve@npm:^1.20.0, resolve@npm:^1.22.4":
"resolve@npm:^1.10.0, resolve@npm:^1.14.2, resolve@npm:^1.20.0, resolve@npm:^1.22.1, resolve@npm:^1.22.4":
version: 1.22.8
resolution: "resolve@npm:1.22.8"
dependencies:
Expand All @@ -9883,7 +9885,7 @@ __metadata:
languageName: node
linkType: hard

"resolve@patch:resolve@^1.10.0#~builtin<compat/resolve>, resolve@patch:resolve@^1.10.1#~builtin<compat/resolve>, resolve@patch:resolve@^1.14.2#~builtin<compat/resolve>, resolve@patch:resolve@^1.20.0#~builtin<compat/resolve>, resolve@patch:resolve@^1.22.4#~builtin<compat/resolve>":
"resolve@patch:resolve@^1.10.0#~builtin<compat/resolve>, resolve@patch:resolve@^1.14.2#~builtin<compat/resolve>, resolve@patch:resolve@^1.20.0#~builtin<compat/resolve>, resolve@patch:resolve@^1.22.1#~builtin<compat/resolve>, resolve@patch:resolve@^1.22.4#~builtin<compat/resolve>":
version: 1.22.8
resolution: "resolve@patch:resolve@npm%3A1.22.8#~builtin<compat/resolve>::version=1.22.8&hash=c3c19d"
dependencies:
Expand Down Expand Up @@ -10101,7 +10103,7 @@ __metadata:
languageName: node
linkType: hard

"semver@npm:7.5.4, semver@npm:^7.0.0, semver@npm:^7.1.1, semver@npm:^7.1.2, semver@npm:^7.3.2, semver@npm:^7.3.4, semver@npm:^7.3.5, semver@npm:^7.3.7, semver@npm:^7.5.2, semver@npm:^7.5.3, semver@npm:^7.5.4":
"semver@npm:7.5.4, semver@npm:^7.0.0, semver@npm:^7.1.1, semver@npm:^7.1.2, semver@npm:^7.3.2, semver@npm:^7.3.4, semver@npm:^7.3.5, semver@npm:^7.3.7, semver@npm:^7.3.8, semver@npm:^7.5.2, semver@npm:^7.5.3, semver@npm:^7.5.4":
version: 7.5.4
resolution: "semver@npm:7.5.4"
dependencies:
Expand All @@ -10112,7 +10114,7 @@ __metadata:
languageName: node
linkType: hard

"semver@npm:^6.1.0, semver@npm:^6.3.0, semver@npm:^6.3.1":
"semver@npm:^6.3.0, semver@npm:^6.3.1":
version: 6.3.1
resolution: "semver@npm:6.3.1"
bin:
Expand Down