chore: disable node/no-missing-require eslint rule enforced by TS

jest-community · Jul 13, 2023 · 463418f · 463418f
1 parent 4b35486
commit 463418f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -54,8 +54,9 @@ module.exports = {
     ],
     'sort-imports': ['error', { ignoreDeclarationSort: true }],
     'require-unicode-regexp': 'error',
-    // TS covers this
+    // TS covers these 2
     'node/no-missing-import': 'off',
+    'node/no-missing-require': 'off',
     'node/no-unsupported-features/es-syntax': 'off',
     'node/no-unsupported-features/es-builtins': 'error',
     'import/no-commonjs': 'error',

diff --git a/src/rules/__tests__/unbound-method.test.ts b/src/rules/__tests__/unbound-method.test.ts
@@ -126,7 +126,7 @@ const requireRule = (throwWhenRequiring: boolean) => {
 
   TSESLintPluginRef.throwWhenRequiring = throwWhenRequiring;
 
-  // eslint-disable-next-line @typescript-eslint/no-require-imports,node/no-missing-require
+  // eslint-disable-next-line @typescript-eslint/no-require-imports
   return require('../unbound-method').default;
 };
 
@@ -158,7 +158,7 @@ describe('error handling', () => {
 
       jest.resetModules();
 
-      // eslint-disable-next-line @typescript-eslint/no-require-imports,node/no-missing-require
+      // eslint-disable-next-line @typescript-eslint/no-require-imports
       expect(() => require('../unbound-method').default).toThrow(/oh noes!/iu);
     });
   });