fix: implement CallbackTestRunnerInterface instead of extending CallbackTestRunner class
#134
Conversation
| return class BaseTestRunner extends CallbackTestRunner { | ||
| ) { | ||
| return class BaseTestRunner implements CallbackTestRunnerInterface { | ||
| #globalConfig: Config.GlobalConfig; |
There was a problem hiding this comment.
TS is fine with #, but does not allow to have private _globalConfig: "Property '_globalConfig' of exported class expression may not be private or protected."
Hm.. Should Node 12 support be dropped before merging this change?
create-jest-runner/.github/workflows/nodejs.yml
Lines 36 to 37 in 445b564
There was a problem hiding this comment.
do we need to use # now, or is that just a refactoring?
There was a problem hiding this comment.
Can be public as well. Is that fine?
private was not allowed by TS, so I went for #. But before #113 this field was marked public. Can stay like that too.
There was a problem hiding this comment.
Private is fine 🙂 this class isn't used by consumers anyways
2 participants
Following up #113
As reported in jest-community/jest-runner-tsd#97
jest-runnerhas to be moved to dependencies instead of peer dependencies. This problem was introduced in #113, becauseCallbackTestRunnerclass got imported from'jest-runner'instead of types only import.Switching to
CallbackTestRunnerInterfaceinstead of extending the class should fix the issue.Closes jest-community/jest-runner-tsd#97