Adding tests for validation and login #15
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| package http | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "fmt" | ||
| "github.com/stretchr/testify/require" | ||
| "net/http" | ||
| "net/http/httptest" | ||
| "testing" | ||
| ) | ||
|
|
||
| func TestLoginUserHandler(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| t.Run("Errors", testLoginErrors) | ||
| t.Run("Success", testLoginSuccess) | ||
| } | ||
|
|
||
| func testLoginErrors(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| methodsToTest := []string{http.MethodDelete, http.MethodPost, http.MethodPut, http.MethodPatch, http.MethodOptions} | ||
|
|
||
| for _, method := range methodsToTest { | ||
| t.Run(fmt.Sprintf("Method %s not allowed", method), func(t *testing.T) { | ||
| t.Parallel() | ||
| req, err := http.NewRequest(method, "/", nil) | ||
| require.NoError(t, err) | ||
|
|
||
| resp := assertResponseStatus(t, req, http.StatusMovedPermanently) | ||
| require.Equal(t, "", resp) | ||
| }) | ||
| } | ||
|
|
||
| t.Run("Handle error reading request body", func(t *testing.T) { | ||
jessicamosouza marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| t.Parallel() | ||
| req, err := http.NewRequest(http.MethodGet, "/", &ErrorReader{}) | ||
|
There was a problem hiding this comment. Como |
||
| require.NoError(t, err) | ||
|
|
||
| resp := assertResponseStatus(t, req, http.StatusInternalServerError) | ||
| require.Equal(t, "Error unmarshalling request body\nemail validation failed: invalid email\n", resp) | ||
| }) | ||
|
|
||
| t.Run("Empty body", func(t *testing.T) { | ||
| t.Parallel() | ||
| req, err := http.NewRequest(http.MethodGet, "/", nil) | ||
| require.NoError(t, err) | ||
|
|
||
| resp := assertResponseStatus(t, req, http.StatusBadRequest) | ||
| require.Equal(t, "Empty body\n", resp) | ||
| }) | ||
|
|
||
| t.Run("Error finding user", func(t *testing.T) { | ||
| t.Parallel() | ||
| req, err := http.NewRequest(http.MethodGet, "/", bytes.NewBufferString( | ||
| `{"email":"maria@email.com", "password":"Password123!"}`)) | ||
| require.NoError(t, err) | ||
|
|
||
| resp := assertResponseStatus(t, req, http.StatusBadRequest) | ||
| require.Equal(t, "[usermodels] user not found\n", resp) | ||
| }) | ||
| } | ||
|
|
||
| func testLoginSuccess(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| t.Run("Successful body read", func(t *testing.T) { | ||
| t.Parallel() | ||
|
There was a problem hiding this comment. C entendeu direitinho pra que o t.Parallel serve e como ele funciona? |
||
| req, err := http.NewRequest(http.MethodGet, "/", | ||
| bytes.NewBufferString(`{"email":"john@doe.com","password":"Password123!"}`)) | ||
| require.NoError(t, err) | ||
|
|
||
| resp := assertResponseStatus(t, req, http.StatusOK) | ||
| require.Equal(t, "LoginUserPayload logged successfully!", resp) | ||
| }) | ||
| } | ||
|
|
||
| func assertResponseStatus(t *testing.T, req *http.Request, status int) string { | ||
|
There was a problem hiding this comment. Quando vc define alguma coisa em um arquivo de teste, essa parada fica disponível pra todos os testes que usem o mesmo pacote. Como essa função faz assertion do status HTTP da resposta de LoginUserHandler especificamente, vale um ou outro dos abaixo: Um: Deixar claro no nome que a assertion é para Outro: Aceitar como parâmetro a função. Ficaria algo assim: func assertResponseStatus(t *testing.T, fn http.HandleFunc, req *http.Request, status int) string {
t.Helper()
rec := httptest.NewRecorder()
fn(rec, req)
require.Equal(t, status, rec.Code)
return rec.Body.String()
}
// Usado assim, por exemplo:
assertResponseStatus(t, LoginUserHandler, req, http.StatusOK)Se você optar por outro, vale criar um arquivo Outra dica legal é usar |
||
| rec := httptest.NewRecorder() | ||
| LoginUserHandler(rec, req) | ||
| require.Equal(t, status, rec.Code) | ||
| return rec.Body.String() | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acho que assim ficaria mais fácil de entender. Pense no código como uma leitura, quanto mais claros os nomes das variáveis forem, menos contexto precisa ser carregado na cabeça pra entender o código.