Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The plugin only fetches the first 1000 images #343

Open
kilburn opened this issue Aug 21, 2019 · 4 comments · May be fixed by #344
Open

The plugin only fetches the first 1000 images #343

kilburn opened this issue Aug 21, 2019 · 4 comments · May be fixed by #344

Comments

@kilburn
Copy link

kilburn commented Aug 21, 2019

When an s3 bucket has more than 1000 images, this plugin only fetches the first 1000. This is because the listObjectsV2 call returns a maximum of 1000 items (and forces the application to fetch the remainder in subsequent requests) as explained in the docs.
kilburn added a commit to kilburn/gatsby-source-s3-image that referenced this issue Aug 21, 2019
@kilburn
Fetch all items in the bucket
53010bb 
AWS API limits list responses to 1000 items. If the bucket is larger,
subsequent requests are needed to actually fetch all of the items in the
bucket.

This commit implements iteration logic to keep fetching while there are
more (not-returned-yet) results.

Fixes jessestuart#343
@kilburn kilburn linked a pull request Aug 21, 2019 that will close this issue
Open
kilburn added a commit to kilburn/gatsby-source-s3-image that referenced this issue Aug 21, 2019
@kilburn
Fetch all items in the bucket
e729567 
AWS API limits list responses to 1000 items. If the bucket is larger,
subsequent requests are needed to actually fetch all of the items in the
bucket.

This commit implements iteration logic to keep fetching while there are
more (not-returned-yet) results.

Fixes jessestuart#343
kilburn added a commit to kilburn/gatsby-source-s3-image that referenced this issue Aug 21, 2019
@kilburn
Fetch all items in the bucket
3a78d0b 
AWS API limits list responses to 1000 items. If the bucket is larger,
subsequent requests are needed to actually fetch all of the items in the
bucket.

This commit implements iteration logic to keep fetching while there are
more (not-returned-yet) results.

Fixes jessestuart#343
kilburn added a commit to kilburn/gatsby-source-s3-image that referenced this issue Aug 21, 2019
@kilburn
Fetch all items in the bucket
5a40184 
AWS API limits list responses to 1000 items. If the bucket is larger,
subsequent requests are needed to actually fetch all of the items in the
bucket.

This commit implements iteration logic to keep fetching while there are
more (not-returned-yet) results.

Fixes jessestuart#343
@sfivash
Copy link

sfivash commented Sep 28, 2019 •
edited
Loading

I'm running into this issue right now. Thanks for submitting a merge request with the fix for this.

Any plans on merging this fix into the plugin? @jessestuart

@rjmoggach
Copy link

I'm only able to fetch about 340 images of my 2000+ images - any updates on timing for this merge?

@Vacilando
Copy link

Much needed here as well; any news?

@wassim
Copy link

wassim commented Feb 23, 2020 •
edited
Loading

@jessestuart could you merge this please? 😢

tomaszgiedziun pushed a commit to tomaszgiedziun/gatsby-source-s3-image that referenced this issue Oct 15, 2020
@kilburn
Fetch all items in the bucket
2c81cbf 
AWS API limits list responses to 1000 items. If the bucket is larger,
subsequent requests are needed to actually fetch all of the items in the
bucket.

This commit implements iteration logic to keep fetching while there are
more (not-returned-yet) results.

Fixes jessestuart#343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fetch all items in the bucket kilburn/gatsby-source-s3-image
5 participants
@kilburn @Vacilando @rjmoggach @sfivash @wassim