This repository has been archived by the owner on Aug 14, 2019. It is now read-only.
Fix #648: Verify that inputToolbar isFirstResponder before responding to UIKeyboard notifications
#649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
:: JSQMessagesViewController now ignores keyboard frame changes unless the input toolbar `isFirstResponder` :: frame changes are still observed and broadcast, but no action is taken in the controller :: fixes jessesquires#648
:: if inputToolbar is in-motion (i.e. when toolbarBottomLayoutGuide != 0), react to frame change notifications :: this allows the inputToolbar to slide gracefully after it calls `resignFirstResponder` :: this is especially important after jessesquires#646 (or similar explicit handling of the 'keyboard did hide' event) is implemented
| heightFromBottom = MAX(0.0f, heightFromBottom); | ||
|
|
||
| [self jsq_setToolbarBottomLayoutGuideConstant:heightFromBottom]; | ||
| if ([self.inputToolbar.contentView.textView isFirstResponder] || self.toolbarBottomLayoutGuide.constant != 0) { |
There was a problem hiding this comment.
hey @toblerpwn - aren't these 2 conditions mutually inclusive?
that is, if we are the firstResponder, then the layoutGuide will be non-zero.
likewise, if the layoutGuide is non-zero, then we are not the first responder.
|
thanks @toblerpwn - one question for you above. |
This was referenced Aug 8, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #648 by checking verifying that the
inputToolbartextViewisFirstResponder- OR whether it is already 'in motion', i.e. in the process of being hidden AFTER itresignFirstResponderis called.NOTE: The changes introduced in #646 will also need this fix - i.e. the same conditional must be applied to the 'keyboard did hide' notification handler.