Skip to content
This repository has been archived by the owner on Aug 14, 2019. It is now read-only.

fix #480: scrollToBottomAnimated: fix long message handling #644

Merged
merged 2 commits into from
Dec 19, 2014

Conversation

toblerpwn
Copy link
Contributor

fixes #480 - tested in a few other scenarios, and behavior was as expected. should probably be tested further against common layout-style breaking points, however.

in some cases, `Top` alignment is best - this commit handles those cases
@toblerpwn
Copy link
Contributor Author

Correction: in some cases, Top alignment is best. 6a04d75 handles both cases.

@toblerpwn
Copy link
Contributor Author

As was pointed out by @galambalazs in #480 , this PR improves the handling of large cells, but it is still imperfect; although huge cells are shown and scrolled properly to the their bottom, there remains a non-beautiful margin between the bottom (huge) cell and the input toolbar. Ideally we would have a perfect margin.

I would still suggest merging this PR - since it improves on the current state of the project - until a more robust fix can be implemented.

@jessesquires
Copy link
Owner

thanks @toblerpwn ! i'll look at this soon

@toblerpwn
Copy link
Contributor Author

Cool @jessesquires - no rush per se, I'm just running a custom branch 'til these fixes sort themselves out in the main pod one way or another. :)

I've got a couple more things coming your way, too! Boo yah!

@jessesquires jessesquires added this to the Release 6.1.1 milestone Nov 27, 2014
jessesquires added a commit that referenced this pull request Dec 19, 2014
fix #480: scrollToBottomAnimated: fix long message handling
@jessesquires jessesquires merged commit d6c9dd0 into jessesquires:develop Dec 19, 2014
jessesquires added a commit that referenced this pull request Dec 19, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scroll to bottom does not work correctly if the newest message in the conversation is long
2 participants