showTypingIndicator not appearing

[gibo]

The typing indicator does not appear when set to YES, there seems to be space made for it, but it does not render.

This bug can be reproduced using the demo application by modifying the function receiveMessagePressed, insert a return statement after:

self.showTypingIndicator = !self.showTypingIndicator;

Now the user needs to press the '...' buttton in the top right.

The typing indicator should appear the first time it is pressed, but it does not.

[gibo]

calling this directly after solves the issue.
[self.collectionView.collectionViewLayout invalidateLayout];

[jessesquires]

thanks @gibo 👍

[idancali]

So this doesn't seem to work for me @gibo
It looks like viewForSupplementaryElementOfKind in JSQMessagesViewController is not being called

I have gotten it to intermittently show by insuring I only enable/disable it once for each state.

• (void)showTypingActivityIndicator{
  // This seems fragile so check the state first
  if (!self.showTypingIndicator) {
  self.showTypingIndicator = YES;
  DDLogVerbose(@"showTypingActivityIndicator");
  }
  }
• (void)hideTypingActivityIndicator{
  // This seems fragile so check the state first
  if (self.showTypingIndicator) {
  self.showTypingIndicator = NO;
  DDLogVerbose(@"hideTypingActivityIndicator");
  }
  }

The animations mostly seem to be working but the indicator image isn’t rendering.

I tried Rob’s:

[self.collectionView.collectionViewLayout invalidateLayout];

But I got a NSInternalInconsistencyException and while the indicator was shown it shot up the page as though it was a normal message.

Thanks for pointing to good place to start trying to fix it ...

Also on the iPad once self.showTypingIndicator = NO; animation has completed it causes the all the message bubbles to start shaking and the shaking increases after each call to self.showTypingIndicator = NO;

Also got a crash:

0 CoreFoundation 0x00000001885def50 exceptionPreprocess + 132
1 libobjc.A.dylib 0x0000000194ae81fc objc_exception_throw + 56
2 CoreFoundation 0x00000001885dee10 +[NSException raise:format:arguments:] + 112
3 Foundation 0x0000000189116db4 -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 108
4 UIKit 0x000000018b73742c -[UICollectionView createPreparedSupplementaryViewForElementOfKind:atIndexPath:withLayoutAttributes:applyAttributes:] + 648
5 UIKit 0x000000018b60a7a8 -[UICollectionView updateVisibleCellsNow:] + 4180
6 UIKit 0x000000018b60637c -[UICollectionView layoutSubviews] + 256
7 UIKit 0x000000018b5a2ff8 -[UIView(CALayerDelegate) layoutSublayersOfLayer:] + 344
8 QuartzCore 0x000000018b194258 -[CALayer layoutSublayers] + 180
9 QuartzCore 0x000000018b18ee20 CA::Layer::layout_if_needed(CA::Transaction) + 296
10 QuartzCore 0x000000018b18ecd8 CA::Layer::layout_and_display_if_needed(CA::Transaction) + 28
11 QuartzCore 0x000000018b18e560 CA::Context::commit_transaction(CA::Transaction) + 276
12 QuartzCore 0x000000018b18e304 CA::Transaction::commit() + 420
13 UIKit 0x000000018b5a716c _UIApplicationHandleEventQueue + 9796
14 CoreFoundation 0x000000018859f644 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION* + 20
15 CoreFoundation 0x000000018859e9a0 __CFRunLoopDoSources0 + 252
16 CoreFoundation 0x000000018859cc38 __CFRunLoopRun + 628
17 CoreFoundation 0x00000001884ddc20 CFRunLoopRunSpecific + 448
18 GraphicsServices 0x000000018e1c5c0c GSEventRunModal + 164
19 UIKit 0x000000018b60efdc UIApplicationMain + 1152
20 SecChat 0x0000000100173db0 main (main.m:16)
21 libdyld.dylib 0x00000001950dbaa0 start + 0

On Jun 13, 2014, at 7:19 AM, Dan Calinescu notifications@github.com wrote:

So this doesn't seem to work for me @gibo
It looks like viewForSupplementaryElementOfKind in JSQMessagesViewController is not being called

—
Reply to this email directly or view it on GitHub.

[dennisfarandy]

this bug happens to me too.. need to fix this soon thanks 👍

[laynemoseley]

Any updates on this?

[SebastianBO]

Same, any updates on this? :)

[laynemoseley]

I've noticed that it appears sometimes. I think there is an issue when there are only a few messages on the screen. When there are many, like 20+, it seems to work pretty well.

[jessesquires]

now fixed via 5728275 if springiness = NO

[jessesquires]

closing as fixed, see #409

[gmansata6290]

@jessesquires
You guys have done a great job by providing this as a open source library. I really appreciate the work you and your team has done. I have used this library in my app. My app is live. So I just wanted to add this feature in my app as well. But I tried out in swift it didn't work. Then I looked in the sample also.

I just want to know ShowTypingIndicator feature is working in Objective - C example, but not in the Swift example. Can you help me out in this?