Custom Font: message is not displayed completely when using custom font, or non-default font size

[harshitaahuja]

I added below code in viewdidload method in JSQDemoViewController.m .It shows starange behavior with message having even number of lines shown in screenshot.

self.collectionView.collectionViewLayout.messageBubbleFont = [UIFont fontWithName:@"HelveticaNeue-Light" size:17.0f];

[mplulu]

same issue

[jessesquires]

hey @harshitaahuja & @hgia1234

this shouldn't be happening 😢

are you changing anything else other than the font?

[mplulu]

I used FuturaLT-Book.ttf font. I tried with other system font size, all worked fine. So I started to think that the font is the problem.
https://www.dropbox.com/s/li07m27xw4lcklf/FuturaLT-Book.ttf
This is the font file. If you can give it a look it will be great. May be this is a bug about NSString boundingRectWithSize or the font file that you can't do anything about

[jessesquires]

@hgia1234 - thanks for the info!

this makes sense. string size calculations are difficult. i remember now, i've only test this with different system font sizes.

[mplulu]

I also did some research about it. I think boundingRectWithSize is the problem according to this http://stackoverflow.com/questions/19398674/sizewithfont-method-is-deprecated-boundingrectwithsize-is-returning-wrong-value. But not sure. Normally I create a temp UILabel, set it and call sizeToFit, which I think may be slower than boundingRectWithSize (I have never done a performance test for this, so I just "think").

Thanks for this amazing library btw 👍

[harshitaahuja]

I used "HelveticaNeue-Light" which is a provided font by ios. So the issue couldn't be with font file. I am using this font with boundingRectWithSize for calculating size of UILabel its is working fine. It is working fine with "HelveticaNeue-Bold"/"HelveticaNeue-Medium" but not with "HelveticaNeue-Light". Still facing the issue.

[somewacko]

Same issue with another custom font (Bariol-Regular.otf). Tried HelveticaNeue and HelveticaNeue-Light but that wouldn't work either 

If I get the chance I can investigate more this weekend. Great library though, btw :D

EDIT: HelveticaNeue-Light (size 14) seems to be working... Definitely not HelveticaNeue (14) though.

[yforjindam]

This change breaks the layout for short strings. Try testing it with the string "Hello" and you will see that it stretches the bubble width beyond the word "Hello" adding a ton of unnecessary padding. I tested with multiple fonts and was able to reproduce the issue. Rolling back the change fixes this for me. I am certain this will affect others so I don't think the issue can be marked as closed.

[yforjindam]

[yforjindam]

Here is what it looks like before this change: