Update parser create method for PHP-Parser v5

[matthewpaulking]

I had a weird bug where tinkeray just stopped working all together:

After digging around a bit, I found that the ParserFactory::create() method was removed in nikic/PHP-Parser v5 (see: https://github.com/nikic/PHP-Parser/blob/master/UPGRADE-5.0.md#changes-to-the-parser-factory). They propose using one of three methods, so I picked out createForHostVersion() as probably the best replacement. This method also exists in v4 of nikic/PHP-Parser, so this should still work in older versions.

I think this is probably related to laravel/tinker#170

Manually changing this line in my installed version of tinkeray seems to have fixed the problem, but I'm not sure how to do more thorough testing.

[neilgilmour]

I was getting the same issue, and @matthewpaulking's change worked for me.

[uportnykh]

@matthewpaulking Thanks for sharing the fix! I ended up using a similar code, even though it doesn't seem to work in v4 of nikic/PHP-Parser for me, so I use this:

if (! method_exists('PhpParser\ParserFactory', 'create')) {
    $parser = (new PhpParser\ParserFactory)->createForHostVersion();
} else {
    $parser = (new PhpParser\ParserFactory)->create(PhpParser\ParserFactory::PREFER_PHP7);
}

[jesseleite]

Interesting yeah. I guess we can't guarantee which version they'll be on, so I threw a ternary in there to cover both. Eventually we can just use the new method 👍

Thanks fellas!

[matthewpaulking]

Good catch @uportnykh, and thanks very much @jesseleite!

[jesseleite]

Team effort!