feat(build): add riscv64 to release binaries#5435
Closed
xingzihai wants to merge 1 commit intojesseduffield:masterfrom
Closed
feat(build): add riscv64 to release binaries#5435xingzihai wants to merge 1 commit intojesseduffield:masterfrom
xingzihai wants to merge 1 commit intojesseduffield:masterfrom
Conversation
Add riscv64 architecture to goreleaser config to support RISC-V hardware (VisionFive 2, LicheePi 4A, SiFive boards). Go has supported GOARCH=riscv64 as a first-class target since Go 1.14, and lazygit builds with CGO_ENABLED=0, so no special toolchain is required. Fixes jesseduffield#5419
Collaborator
|
Closing as not planned, see #5419 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
riscv64to thegoarchlist in.goreleaser.ymlto support RISC-V hardware.Changes
riscv64architecture to goreleaser configlazygit_<version>_linux_riscv64.tar.gz(andfreebsd_riscv64) in releasesWhy
Users on RISC-V hardware (VisionFive 2, LicheePi 4A, SiFive boards) currently must build from source. Since lazygit builds with
CGO_ENABLED=0and Go has supportedGOARCH=riscv64since Go 1.14, this is a straightforward addition with no special toolchain required.Testing
The issue author has verified that lazygit builds and tests pass on native riscv64 hardware: https://github.com/gounthar/lazygit/actions/runs/23536886583
Fixes #5419