Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll views up if needed to show all their content #3839

Merged
merged 2 commits into from
Aug 24, 2024
Merged

Scroll views up if needed to show all their content #3839

merged 2 commits into from
Aug 24, 2024

Commits on Aug 24, 2024

  1. Bump gocui

    @stefanhaller
    stefanhaller committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    0aa3514 View commit details
    Browse the repository at this point in the history

  2. Scroll views up if needed to show all their content 

    There are many situations where this can arise. Some examples are:
- the terminal window is small, and you are showing a view that shows more
  content than fits into the view port, and the view is scrolled all the way
  down; now you resize the terminal window to a taller size. Previously, the
  scroll position of the view would stay the same, so it would add blank space
  at the bottom; now it will scroll to fill that blank space with content
- expandFocusedSidePanel is on, you go to the bottom of a list view, now switch
  to a different panel, then scroll that (now unfocused) panel all the way down
  with the scroll wheel; now you focus that panel again. It becomes larger
  because of the accordion behavior, but would show blank space at the bottom.

And probably others that I can't remember right now. I only remember that I
always found it confusing to look at a view that had blank space at the bottom
even though it had more content to scroll into view.
    @stefanhaller
    stefanhaller committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    6114f69 View commit details
    Browse the repository at this point in the history