Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert TranslationSets to json #3649

Merged
merged 5 commits into from
Jun 23, 2024
Merged

Convert TranslationSets to json #3649

merged 5 commits into from
Jun 23, 2024

Commits on Jun 23, 2024

  1. Remove unused struct

    @stefanhaller
    stefanhaller committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    02aeb61 View commit details
    Browse the repository at this point in the history

  2. Convert the non-English translation sets to JSON files 

    We write a hacky, one-off script to do that. We need this script only once, so
we don't bother polishing it much. We'll re-purpose it later in the branch to
convert the English translation set to JSON; that is an operation that we need
to do regularly in the future.
    @stefanhaller
    stefanhaller committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    1e123e2 View commit details
    Browse the repository at this point in the history

  3. Remove all empty strings 

    I guess I could have coded this into the export script, but I was too lazy and
just did it manually in VS Code, which was easy enough.
    @stefanhaller
    stefanhaller committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    b34de70 View commit details
    Browse the repository at this point in the history

  4. Remove non-English translation sets, read them from JSON instead

    @stefanhaller
    stefanhaller committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    98e5fd7 View commit details
    Browse the repository at this point in the history

  5. Change script to write only the English translation set to JSON 

    We will have to do this regularly in order to upload it to Crowdin (or Weblate
or whatever translation system we are going to use).

Unlike the non-English JSON files, the en.json file is not committed to the git
repo.
    @stefanhaller
    stefanhaller committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    741d9a2 View commit details
    Browse the repository at this point in the history