Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stashing all staged #3568

Closed
wants to merge 3 commits into from
Closed

Fix stashing all staged #3568

wants to merge 3 commits into from

Conversation

dsolerh
Copy link

@dsolerh dsolerh commented May 16, 2024 •
edited
Loading

  • PR Description

  • Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

dsolerhww added 3 commits May 16, 2024 23:48
Add helper to see if there's any untaged changes
b906039
Use regular Push if there's no unstaged changes
6a5c939
Test the fix
c12ed4d 
- Rename this file for clarity on the test porpose
- Test that if all files are staged and no name is given there's no error
- Add the tests to the list
@dsolerh dsolerh mentioned this pull request May 16, 2024
Closed
@stefanhaller stefanhaller mentioned this pull request May 17, 2024
Closed
@dsolerh dsolerh closed this May 17, 2024
@dsolerh dsolerh deleted the fix/stashing-all-staged branch May 17, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dsolerh