Fix bug related to limit view #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
=======================================
Coverage 94.27% 94.27%
=======================================
Files 13 13
Lines 1782 1782
=======================================
Hits 1680 1680
Misses 99 99
Partials 3 3Continue to review full report at Codecov.
|
|
@jesseduffield this is done |
golangcibot
reviewed
Oct 31, 2018
| @@ -180,6 +180,7 @@ func (gui *Gui) layout(g *gocui.Gui) error { | |||
| } | |||
| v.Title = gui.Tr.SLocalize("NotEnoughSpace") | |||
| v.Wrap = true | |||
| g.SetCurrentView(v.Name()) | |||
There was a problem hiding this comment.
Error return value of g.SetCurrentView is not checked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #312